#14434 - AdminSite should check self.has_permission in self.login

2010-10-10 Thread Brandon Konkle
A commenter on my blog brought up something about AdminSite that breaks permission customization if you want to remove user.is_staff. AdminSite.login explicitly checks user.is_active and user.is_staff (http://github.com/django/django/blob/master/django/contrib/admin/sites.py#L341). AdminSite.

Re: #6735 -- Class based generic views: call for comment

2010-10-01 Thread Brandon Konkle
On Oct 1, 2010, at 10:20 AM, Alex Gaynor wrote: > Not really. The big win from a class-based view is not being able to > store state, you can do that with local variables, it's being able to > override parts of the behavior without needing to rewrite the entire > view, or add 101 parameters. If