Re: Silently capturing all UnicodeDecodeError exceptions in widget rendering

2009-02-22 Thread Ben Gerdemann
On Feb 20, 10:52 pm, Malcolm Tredinnick wrote: > Yes. Non-developer-controlled content (which is usually what's being > converted by filters) should not be allowed to crash template rendering. > The data coming into the template variables could be from a lot of > location and, as a final fallba

Silently capturing all UnicodeDecodeError exceptions in widget rendering

2009-02-20 Thread Ben Gerdemann
I just spent a good part of my afternoon tracking down a bug in my code, that eventually turned out to be a Unicode encoding problem. The reason it took me so long to track down the problem is this code here in 'template/__init__.py': 794 class VariableNode(Node): ... 801 def render(s

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-16 Thread Ben Gerdemann
On Feb 10, 1:43 am, Malcolm Tredinnick wrote: > Ignoring portions of a URL sounds pretty broken. Our goal isn't to be > like other frameworks. It's to behave correctly, in accordance with best > practices for things like URL construction and consumption. I would be a > little unhappy with 'igno

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-08 Thread Ben Gerdemann
On Feb 8, 2:15 pm, Karen Tracey wrote: > I don't have time to devote to this right now, but I'd suggest taking a look > at the svn history of  the tests that check for the ?e=1 redirect.  I have a > vague recollection that it/they may be there as a result of a problem where > incorrect lookup par

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-08 Thread Ben Gerdemann
On Feb 7, 12:35 pm, Alex Gaynor wrote: > On Sat, Feb 7, 2009 at 8:27 AM, Ben Gerdemann wrote: > > A couple things, first the patch still has a pair of TODO comments, so > either those comments are no longer applicable, or what they refer to should > be fixed.  Secondly, it needs

Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-07 Thread Ben Gerdemann
Hello, I'd like to ask what the status of ticked #5833 http://code.djangoproject.com/ticket/5833 is. I see that it's listed as a "maybe" feature for 1.1. The patch is marked "needs improvement," but it's not clear to me from the bug discussion what improvement is being requested. I (gerdemb) hav