Thanks for your feedback! I'll make a PR in the coming days. I just needed
to know does anyone else think this code needs refactoring or I'm doing
useless work.
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" gr
https://github.com/django/django/blob/418263c457636d3301f2068c47f09a0f42e15c52/django/middleware/cache.py#L127
I have an idea how to improve readability of this method. I've already
implemented
it but before creating an issue and PR I decided to discuss it with
community. Maybe
all of this doesn
I'm working on issue #29471. This issue have version 2.0. Do I need to add
version indicator in that case?
if you're fixing a Trac ticket, start the commit message with "Fixed #x
> -- bla bla bla".
>
I still don't understand which of three commits must have that header.
First? Or all of the
I worked on issue and fixed a bug. So a have three commits (in the sequence
they were commited):
- Added regression tests
- Added bugfix
- Added name to AUTHORS
This is my first PR and I have several questions:
1. I don't quite understand about "headers" in commit messages. Which
commit should