Django "makemigrations -- update" donot working

2023-04-06 Thread Saifullah Shahen
in my custom user model, initially, my model looks like this class User(AbstractUser, BaseModelWithUUID): phone = models.CharField(max_length=11, validators=[validate_phone_number]) I do command "makemigrations" which create a initial migration file but after updating my model like this cla

Re: Implement Ruff Linter

2023-04-06 Thread charettes
Strong agree with Adam here. If Ruff current offer is enhanced speed at the cost of a less mature ecosystem I don't think that it's a tradeoff Django should make at the time being. Simon Le jeudi 6 avril 2023 à 08:16:00 UTC-4, Adam Johnson a écrit : > I don't think we should adopt Ruff. It's

Re: Proposal: Check constraints at the model field level

2023-04-06 Thread charettes
Small clarification here. > it should be noted that SQL has both CHECK on the field and table level, >From my understanding CREATE TABLE / ADD COLUMN checks on the field level are really just syntactic sugar for checks at the table level like just like `REFERENCES` usage is syntactic sugar for

Re: Implement Ruff Linter

2023-04-06 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I don't think we should adopt Ruff. It's a new, somewhat experimental project. It wouldn't provide any gains except speed, but that is not really a concern since it still takes a handful of seconds to lint Django with Flake8 and co. On Mon, Apr 3, 2023 at 1:59 PM Jerome Obi wrote: > Hi ! > I use

Re: Stalebot on djangoproject.com issues

2023-04-06 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I agree that we should remove Stalebot. Closing old issues doesn't fix them or provide a reason why they aren’t going to be worked on. On Thu, Apr 6, 2023 at 8:02 AM Sarah Boyce wrote: > From what it sounds, I guess the main value was prompting a one time > spring clean. As there are not that ma

Proposal: Constructing urls outside the request cycle

2023-04-06 Thread Sarah Boyce
Hello 👋 This is a summary of some previous discussions which need opening up to the group 👍 There is a need to have some kind of URL outside the request cycle (such as sending emails which need to create a link). For constructing a correct MEDIA_URL / STATIC_URL we wanted to use the script pr

Re: Stalebot on djangoproject.com issues

2023-04-06 Thread Sarah Boyce
>From what it sounds, I guess the main value was prompting a one time spring clean. As there are not that many issues open in djangoproject.com and all issues will have been re-validated, I think it makes sense to remove it to reduce this additional burden/frustration. There are configurations