Re: Features deprecated in 4.1 / Log out via GET

2022-05-19 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Great. There's some more information on warnings in the docs here: https://docs.djangoproject.com/en/4.0/howto/upgrade-version/#resolving-deprecation-warnings . ‪On Thu, May 19, 2022 at 9:38 PM ‫אורי‬‎ wrote:‬ > Hi Adam, > > I understand, and with `python -W all` I can see this warning (it was w

Re: Features deprecated in 4.1 / Log out via GET

2022-05-19 Thread אורי
Hi Adam, I understand, and with `python -W all` I can see this warning (it was with `python -W error::DeprecationWarning` that I didn't see the warning). Thanks, Uri. אורי u...@speedy.net On Thu, May 19, 2022 at 10:52 PM 'Adam Johnson' via Django developers (Contributions to Django itself) wro

Re: Features deprecated in 4.1 / Log out via GET

2022-05-19 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Hi Uri, The view raises a RemovedInDjango50Warning, which on Django 4.1 inherits from PendingDeprecationWarning: https://github.com/django/django/blob/ac6410ec071f53893914c82e820a2320866681df/django/utils/deprecation.py#L12 You'll need to run with "python -W all" or similar to see it (consider de

Features deprecated in 4.1 / Log out via GET

2022-05-19 Thread אורי
Hi, I installed Django 4.1 alpha and ran the tests with deprecation warnings enabled, but I didn't get any deprecation warnings for logging out with get. I have this test: def test_user_can_logout(self): r = self.client.get(path='/logout/') self.assertE

Re: Django 4.1 alpha 1 released

2022-05-19 Thread אורי
Hi Carlton, Thanks for your reply. I created a ticket: https://code.djangoproject.com/ticket/33724 I'm not sure how to create a test. Maybe you should just contain the following code (in a model): def clean_fields(self, exclude=None): if (exclude is None): exclude = []

Re: Django 4.1 alpha 1 released

2022-05-19 Thread Carlton Gibson
Hi Uri, Good spot. The docs have `The optional exclude argument lets you provide a list of field names to exclude from validation.` for `clean_fields()` so expecting a list seems reasonable. 🤔 This was changed in https://github.com/django/django/commit/1ea7e3157d1f9b4db71e768d75ea57e47dbd49f9 — i