Re: Fellow Reports - November 2020

2020-11-17 Thread Mariusz Felisiak
Week ending November 15, 2020. *Triaged: * https://code.djangoproject.com/ticket/32180 - Add a warning if the file system cache location is relative. (accepted) https://code.djangoproject.com/ticket/32178 - Allow database backends to skip tests and mark expected failures (accepted) h

Re: Custom collation support

2020-11-17 Thread Adam Johnson
> > As far as I'm aware, the user is responsible for creating the database so > I'm not sure why a setting is needed here. Maybe someone can enlighten me. This is not the case in tests, so a setting would be needed there at least. (Also I don't like the "create your own DB" approach of Django, i

Re: Custom collation support

2020-11-17 Thread Tom Carrick
I just want to follow up on this as there is one remaining collation related ticket left: https://code.djangoproject.com/ticket/5745 Reading through, it requests two things: a setting in DATABASES for a collation and a model Meta option for table collations. As far as I'm aware, the user is respo

Re: Proposal to add pre-commit

2020-11-17 Thread smi...@gmail.com
Hi All, Thanks for your comments. Adam -- yes, I quite like pre-commit-hooks it reminds me of the 'pick and mix' when I was a kid. We can easily add more here, as I guess the risk is low. I like the idea of running the binaries through the system but I wonder if it's too much here. That is,