Re: HttpResponse headers interface

2020-07-14 Thread Carlton Gibson
Just to be clear: > I think we should keep the old interface. I mean as well as adding the new .headers property. (So +1) (Sorry if that was already clear.) On Tuesday, 14 July 2020 16:41:43 UTC+2, Carlton Gibson wrote: > > I think we should keep the old interface. > > The BC concerns are one

Re: HttpResponse headers interface

2020-07-14 Thread Carlton Gibson
I think we should keep the old interface. The BC concerns are one point: it's every bit of Django code ever written. To keep __setitem__ &co is a small price to pay not to needlessly break that code. Beyond that though, the proposed API is very nice, but the pendulum will swing back: having r

Re: HttpResponse headers interface

2020-07-14 Thread Jon Dufresne
> I don't see a reason to deprecate it at all just now (though perhaps in _my_ ideal world that would happen at some point), but I'm not sure if it's worth keeping the current interface in the documentation at all? IMHO, we should eventually take the advice from the zen of Python "There should be

Re: HttpResponse headers interface

2020-07-14 Thread Tobias Kunze
Hi all, first off: Thank you for your work, Tom, this will be one of the changes that I will start using immediately and then wonder how I got by without. >One further small addition, I think it would be good to be able to pass >> headers into the HttpResponse object > >I'm also behind that. A qu

Re: HttpResponse headers interface

2020-07-14 Thread Adam Johnson
> > I'm wondering though, if we should prefer this interface over the old one, > as it's a bit more explicit in my view. I'd be happy to go through the docs > and change the examples to using the headers attribute directly. > I think it's preferable. The old interface was so unclear. It would als

Re: HttpResponse headers interface

2020-07-14 Thread Tom Carrick
I've pushed a proof of concept here: https://github.com/django/django/pull/13186 I decided to do a bit more than I initially intended. It seems like the headers can be stored as a public interface and single source of truth now, rather than just adding an extra public property based on it, by usin

Re: Admin accessibility

2020-07-14 Thread Thibaud Colas
๐ŸŽ‰ itโ€™s wonderful to see this happening! Re-reading through the whole thing, as Tobias mentioned I also find it very easy to read, and makes a good case. On Tuesday, 14 July 2020 at 09:24:15 UTC+1 t...@carrick.eu wrote: > I've added a PR to the DEPs repo to hopefully get some eyes on it: > http

Re: Admin accessibility

2020-07-14 Thread Tom Carrick
I've added a PR to the DEPs repo to hopefully get some eyes on it: https://github.com/django/deps/pull/69 Thibaud, I think whatever you have the time and motivation for sounds good, all of those things are useful. If you're not sure about all the admin features, I think that's pretty normal. One p