Re: Selected projects for Google Summer of Code 2020

2020-05-06 Thread Ahmad A. Hussein
I'm honestly ecstatic to have been accepted! It's something that I wanted to do since last year when I read about Sage's project after I started using Django. I'll definitely start a blog to document the entire journey and I think it'll help with keeping track of my own progress. Thanks for the

Re: Selected projects for Google Summer of Code 2020

2020-05-06 Thread Adam Johnson
Congratulations Kacper and Ahmad! Thanks to my fellow mentors for their work so far helping filtering the applications. And especially Carlton for keeping us organized. Yes the forum is a great place to keep the conversation. Looking forward to mentoring Ahmad, Adam On Wed, 6 May 2020 at 12:27

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Adam Johnson
> > +1 request.data > > We shouldn’t be POSTists, there is also PUT and PATCH. > Would just like to point out - that's not the proposal. The proposal is to rename the existing request.POST to request.form_data, which is based on parsing application/x-www-form-urlencoded data from request.body. Bro

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Fran Hrženjak
+1 request.query_params If request.method == "POST": thing = request.GET.get("thing") That’s just silly. +1 request.data We shouldn’t be POSTists, there is also PUT and PATCH. And apparently GET requests can also have a body: https://stackoverflow.com/questions/978061/http-get-with-reque

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread אורי
Hi, I also prefer lowercase names since uppercase is usually reserved for constants in Python. The names of the requests ("GET" / "POST") can be used in strings to check the request method (uppercase). But there is no sense in using uppercase names for variables. אורי u...@speedy.net On Wed, May

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Riccardo Magliocchetti
Hello, On 05/05/20 23:26, Adam Johnson wrote: request.GET and request.POST are misleadingly named: - GET contains the URL parameters and is therefore available whatever the request method. This often confuses beginners and “returners” alike. - POST contains form data on POST request

Re: Selected projects for Google Summer of Code 2020

2020-05-06 Thread Kacper Szmigiel
Hello all! TBH I'm still shocked that I got accepted! I don't even know how to express my satisfaction. I would like to thank you for your trust, and promise to do my best. About the communication channels - I will adapt to whatever suits you best. I got used to writing emails, but I can switch

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Ryan Hiebert
I can agree that there might be better things to do, but this falls into the category of warts for me, so I'm +1. Having the name be pythonic is a plus, but avoiding a beginner footgun is better. And I believe the conventions used did indeed come from PHP. There even used to be a parallel to `$_RE

Re: Selected projects for Google Summer of Code 2020

2020-05-06 Thread Sage M. Abdullah
Thanks, Carlton, for the briefing! I agree it's a good idea to utilize the forum for discussions. Aside from the forum and GitHub, I'd suggest Ahmad and Kacper start a blog if you haven't already, and write about your GSoC Journey there. I'm sure folks would enjoy reading how you learn and impl

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Tom Carrick
> This often confuses beginners and “returners” alike. I'm neither a beginner nor returner and I still have to remind myself that request.POST doesn't contain my JSON data. I think it's a positive change. I agree there are things that would provide a better ROI, but people have to be willing to d

Re: Removing url() ?

2020-05-06 Thread Alasdair Nicol
Hi, On Tuesday, 5 May 2020 21:39:35 UTC+1, James Bennett wrote: > > > There's also no reason why url() in particular should be given special > treatment that other deprecated features or APIs don't get. Some other > old-time bits went far more quickly: render_to_response(), for example, got > t

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Steven Mapes
Ah yes that's true, totally forgot about request.body just then even though I was using it a few days ago. So yes renaming it would help in that regard as I do remember seeing a few S/O question where it's confused people in the past. Mr Steven Mapes Software Development and Solutions E: st...@

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Adam Johnson
> > I always took the capitalisation of GET &co to come from HTTP > — I'd say that's where PHP > took it from too but 🤷‍♀️ > Yes GET and POST are capitalized in HTTP, but then COOKIES is not (Set-Cookie / Cookies headers), and FILES and META aren't dir

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Steven Mapes
Combined them would be very very bad and you would have the same problems as with $_REQUEST in PHP where you have to decide which one wins as you can make a POST to a URL with querystring where one of the parameters uses the same name as a element of the POST and but where the value is different

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Steven Mapes
I also thought it was a taken more form HTTP rather than PHP but if this is changed please do not use *request.form_data* as that is also misleading as you can POST many more sources than form data such as with APIs. post_data would be much clearer. On Tuesday, 5 May 2020 22:26:34 UTC+1, Adam J

Re: Removing url() ?

2020-05-06 Thread Steven Mapes
This is the big thing for me which seems to be have been forgotten. If you need to quickly upgrade a Django project from using url to re_path the fastest way with the least amount of code changes is to simply alias the import in your urls.py files I.E ```from django.urls import re_path as url``

Status of 3.1 release blockers.

2020-05-06 Thread Mariusz Felisiak
Hi y'all, Time to begin release process for the next major release, Django 3.1! The 3.1 feature freeze is scheduled (according to https://code.djangoproject.com/wiki/Version3.1Roadmap) for May 11. We'll probably release the alpha a few days later. We have a few larger patches we want to finish

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Raffaele Salmaso
For me it's a good move (the best would be to have request.data as with DRF). I've done this kind of "upgrade" from Django request.{GET,POST} to DRF request.{query_params,data} and it was quite trivial (search and replace). At the same time it forced me to check the code for correctnes, and I found

Re: Removing url() ?

2020-05-06 Thread אורי
Thank you, Carlton. אורי u...@speedy.net On Wed, May 6, 2020 at 10:06 AM Carlton Gibson wrote: > Hi Uri. > > On 6 May 2020, at 08:32, ⁨אורי⁩ <⁨u...@speedy.net⁩> wrote: > > Although I'm not sure why it was deprecated and renamed to re_path(). > > > It was part of the effort to simplify the URL r

Re: Removing url() ?

2020-05-06 Thread Carlton Gibson
Hi Uri. > On 6 May 2020, at 08:32, ⁨אורי⁩ <⁨u...@speedy.net⁩> wrote: > > Although I'm not sure why it was deprecated and renamed to re_path(). It was part of the effort to simplify the URL routing, as part of Django 2.0 https://docs.djangoproject.com/en/3.0/releases/2.0/#simplified-url-routing

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-06 Thread Jure Erznožnik
I agree. If anything, I've always had issues with GET & POST being different entities in the first place, but never with their names. I would really like to see an entity combining both of them. THAT one, maybe the preferred way of doing so, would be lowercase, but RAW representations of incomi