Re: Discuss ticket 20264: URLValidator should allow underscores in local hostname

2020-04-16 Thread Pavel Savchenko
Thank you Adam, This is more or less what I ended up doing, sans the replace call, very neat! And thanks a lot for the expert advice, everyone! For the time being at least, it seems we have an agreement on not allowing non-strict validation into Django and I have to agree it just makes sense

Re: Discuss ticket 20264: URLValidator should allow underscores in local hostname

2020-04-16 Thread Adam Johnson
> > Folks wanting this can subclass URLValidator. > For anyone who does want this, the subclass is not so much work. You can inherit the regex pieces from URLValidator and edit them to insert _ as a valid character: In [18]: import re ...: ...: from django.core.validators import URLValida

Re: New Merger nomination.

2020-04-16 Thread charettes
I cast my vote in favor of Claude's nomination as well. Le jeudi 16 avril 2020 16:16:31 UTC-4, Adam Johnson a écrit : > > This has fallen by the wayside, let's try restarting. > > As Carlton points out, Claude hasn't been merging in code without others > reviewing it. But as I understand it is us

Re: New Merger nomination.

2020-04-16 Thread Adam Johnson
This has fallen by the wayside, let's try restarting. As Carlton points out, Claude hasn't been merging in code without others reviewing it. But as I understand it is useful to keep translations moving that he can merge in his or others' (accepted) PR's. It gets us to the minimum of three mergers,

Re: Fellow Reports - April 2020

2020-04-16 Thread Mariusz Felisiak
Week ending April 12, 2020. *Triaged:* https://code.djangoproject.com/ticket/31428 - Allow empty message in management command stdout and stderr proxies. (accepted) https://code.djangoproject.com/ticket/29069 - Static file serving does not call request_finished signal. (fixed) https://code.djang