Re: Suggestion: Add validators to Model Meta options

2019-12-16 Thread Adam Johnson
Hi Mathias I feel like this has been suggested on the mailing list or ticket tracker before, a few years ago. However after a quick check I can't find the discussion/ticket in mind. Perhaps if you hunt a bit better than me you can find it. I think it's definitely a whole in the validation API. I

Re: Suggestion to change the Logger date format to ISO 8601

2019-12-16 Thread Adam Johnson
Hi I think the change you're referring to is in runserver: https://github.com/django/django/blob/ff00a053478fee06bdfb4206c6d4e079e98640ff/django/core/servers/basehttp.py#L132 . Django uses a function from the standard library wsgiref simple server here to generate server_time which is then shown i

Re: Adding json lines (jsonl) serializer ro django

2019-12-16 Thread Adam Johnson
Hi Ali Thanks for coming back to this. As I wrote on the ticket I'd be in favour of adding this. If you've got some code already it'd be good to see it in a PR As for your question about overly long lines I think the .replace() style is fine, or a consrtuction like this: ''.join([ "{" '

Re: Forms submitted by bots

2019-12-16 Thread Kye Russell
Due to the cat-and-mouse nature inherent in this sort of request, and the community’s expectation of feature stability in Django, I feel that a third-party app is not the appropriate place for a feature like this. If the Django documentation doesn’t already do so, perhaps it could mention this

Re: Forms submitted by bots

2019-12-16 Thread אורי
Hi, On Sun, Dec 15, 2019 at 9:55 AM James Bennett wrote: > Since this discussion seems to be exclusively about how to use Django, > please take it to the django-users mailing list; the django-developers list > is not an appropriate place for this topic. > This is about my feature request "Preve

Adding json lines (jsonl) serializer ro django

2019-12-16 Thread Ali Vakilzade
Hey! A few month ago I opened a ticket for adding jsonl support to django serializers, I have added a basic patch as the starting point but my ticket was closed because it needed more discussion on the mailing list, I'm willing to work more on my patch to reach a final state (adding more tests

Suggestion to change the Logger date format to ISO 8601

2019-12-16 Thread Leon Albrecht
At the moment Django is using "DD/MMM/ hh:mm:ss", but since 1988 there exists an ISO to format dates like this: "YYY-DD-MM hh:mm:ss" this is not a majot change and i've searched for to do it myself but according to the python logger libary this format is already in use, but Django apperantl

Re: Forms submitted by bots

2019-12-16 Thread Matemática A3K
On Sun, Dec 15, 2019 at 2:54 AM James Bennett wrote: > Since this discussion seems to be exclusively about how to use Django, > please take it to the django-users mailing list; the django-developers list > is not an appropriate place for this topic. > I agree :) > -- > You received this messag

Suggestion: Add validators to Model Meta options

2019-12-16 Thread Mathias Weirsøe Klitgaard
Hi Django Developers, I'm new to contributing and from what I gathered, I should ask here before opening a ticket. Right now the way to validate a model as a whole is to override Model.clean(). I have 2 problems with this: 1) If you do multiple checks that raise ValidationErrors, it is tedious

Re: Improving error message for admin.E202

2019-12-16 Thread Mariusz Felisiak
It's safe to make change to warning messages. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr..

Improving error message for admin.E202

2019-12-16 Thread Shubham Singh
I am new to contributing to django, and i have picked up a ticket listed as easy picking #31086 . It states to make the admin E.202 message (admin inline having, multiple foreign keys to the same parent model), to recommend specifying fk_name. To do

Re: Fellow Reports - December 2019

2019-12-16 Thread Mariusz Felisiak
Week ending December 15, 2019. *Triaged:* https://code.djangoproject.com/ticket/31074 - Errors model abstract testing. (invalid) https://code.djangoproject.com/ticket/31075 - CSRF token missing or incorrect when File upload path not exist. (worksforme) https://code.djangoproject.com/ticket/31073