On Sunday, March 17, 2019 at 9:43:29 PM UTC-4, Alexey Tsivunin wrote:
>
> I'm working on issue #29471. This issue have version 2.0. Do I need to add
> version indicator in that case?
>
>
No, the "Version" flag on the ticket merely indicates when the ticket was
reported.
> if you're fixing a T
I'm working on issue #29471. This issue have version 2.0. Do I need to add
version indicator in that case?
if you're fixing a Trac ticket, start the commit message with "Fixed #x
> -- bla bla bla".
>
I still don't understand which of three commits must have that header.
First? Or all of the
Week ending March 16, 2019
Triaged
---
https://code.djangoproject.com/ticket/30255 - docutils reports an error
rendering view docstring when the first line is not empty (accepted)
Reviewed/committed
--
https://github.com/django/django/pull/11075 - Fixed #30161 -- Added
I can be a quite useful option when mergers have to perform small typos and
code style tweaks before a merge.
I'm not sure it's worth documenting given it's the default value though.
Simon
Le dimanche 17 mars 2019 15:17:32 UTC-4, Adam Johnson a écrit :
>
> 3. I believe I’ve seen Tim use the ma
3. I believe I’ve seen Tim use the maintainers’ edits feature. Perhaps we
should guide towards its usage?
On Sun, 17 Mar 2019 at 17:21, Aymeric Augustin <
aymeric.augus...@polytechnique.org> wrote:
> Hello Alexey,
>
> Thanks for contributing!
>
> 1. You should make a PR against master and, if you
Hello Alexey,
Thanks for contributing!
1. You should make a PR against master and, if you're fixing a Trac ticket,
start the commit message with "Fixed #x -- bla bla bla".
Version indicators such as [2.0.x] are added when patches are backported to
stable branches. You don't need to care ab
I worked on issue and fixed a bug. So a have three commits (in the sequence
they were commited):
- Added regression tests
- Added bugfix
- Added name to AUTHORS
This is my first PR and I have several questions:
1. I don't quite understand about "headers" in commit messages. Which
commit should
