Fellow Report - September 2, 2017

2017-09-02 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28550 - auth's login/logout() views drop options passed as args rather the kwargs (accepted) https://code.djangoproject.com/ticket/28540 - When you save three or more ImageField in admin file perm = 0o600 (needsinfo) https://code.djangop

Re: Custom Join Conditions

2017-09-02 Thread Shai Berger
I think that giving this funcionality names that follow the patterns of select_related() or prefetch_related() is bad, because although it is very close to them in subdomains (dealing with relations), its functionality is much closer to annotate(). In particular, alias is better than to_attr bec

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
OK, I drafted an implementation for django.forms.FileField to support `multiple` as an argument. https://github.com/django/django/pull/9011 I would appreciate some feedback. If you like the design, I’ll try to add documentation and better tests tomorrow. Thanks -Joe :) -- Johannes Hoppe Fon:

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
There is another thing I just come across while working on the form implementation. I realised, that there are multiple ways to extend the ClearableFileInput to support multiple files. More specifically the clear checkbox. Should there be only one checkbox to clear all files or individual once t

Re: Custom Join Conditions

2017-09-02 Thread Adam Johnson
I think filter_related is a good name, it's not that confusing that it sounds like select_related / prefetch_related. The current name is a bit weird because it's an adj + noun, it doesn't really say how it *modifies* the QuerySet, it sounds more declarative. to_attr is also better, as it aligns w

Re: Add support for multiple file fields

2017-09-02 Thread Melvyn Sopacua
On Sat, Sep 2, 2017 at 10:37 AM, Adam Johnson wrote: > ArchiveField sounds a bit too specific for Django core, the most common case > for uploading multiple files would probably be to access them individually, > which it would prevent. Yeah, was on the fence on that one myself. The use cases are

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
Interesting, I love the discussion. I anticipated, that there are may different solutions and opinions regarding this topic. I will limit the implementation to `django.forms` for now and hope, that more people will voice their opinions regarding a model implementation once this becomes available

Re: Add support for multiple file fields

2017-09-02 Thread Adam Johnson
I agree with Melvyn on the first point. I don't think Django should include model fields that encourage denormalization by default (apart from JSONField etc which are built into the DB). A forms.MultiFileField would make sense but to make storage easy it should somehow translate into multiple rows

Re: Add support for multiple file fields

2017-09-02 Thread Melvyn Sopacua
I don't think a MultiFileField belongs in the model layer. You're violating normalization principles making updates, removals, counts etc, needlessly complex. >From the ModelForm perspective, I can certainly appreciate a multi file form field that I can tell to store each file as a new model insta