Re: Should the Django session-id be hashed?

2017-07-17 Thread 'Chris Griffin' via Django developers (Contributions to Django itself)
Hi Everyone, I took a stab at implementing this. I'd appreciate any feedback on the PR . The 8tracks leak over the weekend highlights the importance of hashing session ids. The attacker o

Re: #28398: Allow management command invocation to suggest for incomplete commands?

2017-07-17 Thread Adam Johnson
I feel like this mostly duplicates the bash completion logic we have, which is also more standard across other CLI's However I agree with Tom that correcting for typos is the main use case, using levehshtein distance is a good idea. Another thing that some CLI's have, like npm or arc is auto-corr

Re: #28398: Allow management command invocation to suggest for incomplete commands?

2017-07-17 Thread Tom Forbes
Vlada: I think this is a great idea for improving the usability of manage.py, especially for newcomers. When I looked your current implementation used a simple 'in' to find suggestions, but this is not great for the most obvious/common use case: typos. I would strongly advocate for using the leven