Re: CITextField base class

2017-02-09 Thread Aymeric Augustin
Hello, I’m not a fan of having every project that needs case-insensitive fields declare: class CICharField(CIText, CharField): pass class CITextField(CIText, TextField): pass class CIEmailField(CIText, EmailField): pass Could Django take care of providing these classes? (And perha

Re: CITextField base class

2017-02-09 Thread Tim Graham
That looks good to me. On Thursday, February 9, 2017 at 4:58:16 AM UTC-5, Mads Jensen wrote: > > I had the use case for shorter text strings in mind when I did the PR. > > > https://github.com/atombrella/django/commit/ae8fe50f34329cbc969c5ac5bd368efd5b42b177 > > <- would this be a better approac

Re: CITextField base class

2017-02-09 Thread Mads Jensen
I had the use case for shorter text strings in mind when I did the PR. https://github.com/atombrella/django/commit/ae8fe50f34329cbc969c5ac5bd368efd5b42b177 <- would this be a better approach? On Wednesday, February 8, 2017 at 6:09:26 PM UTC+1, Tim Graham wrote: > > I thought the mixin idea was