Re: Adding an some warnings, checks, or exceptions for urls

2016-04-25 Thread Robert Roskam
I totally agree. There are circumstances when you'll omit a caret or a dollar sign, but as far as I can think of, it would seem to only be related to an include, so couldn't there be some kind of inspection done on whether there's an include an raise some message to basically say "yeah, I'm sur

Re: Unicode normalization for username field

2016-04-25 Thread Aymeric Augustin
On 25 Apr 2016, at 20:31, Shai Berger wrote: > > On Monday 25 April 2016 21:11:51 Aymeric Augustin wrote: >> >> It’s a -0 from me, not a -1, and it may turn into a +0 as time passes... >> More arguments or opinions, especially backed by data or experience, would >> certainly be useful. > > As f

Re: Change executed raw mysql queries to return timezone aware datetimes.

2016-04-25 Thread Aymeric Augustin
Hi Bryce, #19738 is unrelated to the problem you’re describing. It was fixed in d9521f66 which removed adapters i.e. transformations of parameters passed to the database. You’re talking about the removal of converters i.e. transformations of values returned by the database. It is discussed in

Re: Unicode normalization for username field

2016-04-25 Thread Shai Berger
On Monday 25 April 2016 21:11:51 Aymeric Augustin wrote: > > It’s a -0 from me, not a -1, and it may turn into a +0 as time passes... > More arguments or opinions, especially backed by data or experience, would > certainly be useful. As far as I can see, the force of the push to use non-ASCII use

Re: Unicode normalization for username field

2016-04-25 Thread Aymeric Augustin
Hi Claude, On 24 Apr 2016, at 20:58, Claude Paroz wrote: > > Le samedi 23 avril 2016 14:33:56 UTC+2, Aymeric Augustin a écrit : > > You added a username_validator attribute instead of documenting how to > override the whole username field. Can you elaborate on this decision? I > simplifies th

Re: Adding an some warnings, checks, or exceptions for urls

2016-04-25 Thread 'Tom Evans' via Django developers (Contributions to Django itself)
On Mon, Apr 25, 2016 at 1:00 PM, Robert Roskam wrote: > I realize this is a really, really obvious and easily fixed newbie error. > But here it is: > > urlpatterns = [ > url(r'^sitemap/', > TemplateView.as_view(template_name='brochure/sitemap.html'), > name="sitemap"), > # More urls > ] >

Adding an some warnings, checks, or exceptions for urls

2016-04-25 Thread Robert Roskam
I realize this is a really, really obvious and easily fixed newbie error. But here it is: urlpatterns = [ url(r'^sitemap/', TemplateView.as_view(template_name='brochure/sitemap.html'), name="sitemap"), # More urls ] Sitemap should end with dollar sign. The problem isn't bad when it

Re: is_authenticated as property

2016-04-25 Thread Florian Apolloner
On Saturday, April 23, 2016 at 11:02:07 PM UTC+2, Sven R. Kunze wrote: > > Am Montag, 11. April 2016 18:57:46 UTC+2 schrieb Tim Graham: >> >> Do you think the backwards incompatibility is justified here or do you >> prefer some other solution? >> > > I for one think it is justified here. > Absol

Re: Unicode normalization for username field

2016-04-25 Thread Erik Cederstrand
> Den 24. apr. 2016 kl. 20.58 skrev Claude Paroz : > > - I'm afraid this change may result in boilerplate as most custom user models > will revert to Django's historical (and in my opinion sensible) username > validation rules. > > That's a tough question to estimate. This might be true for m