Re: Django Admin new look

2015-03-04 Thread Riccardo Magliocchetti
Il 05/03/2015 00:37, Curtis Maloney ha scritto: Looks pretty slick, but brings with it all the hassles of the past attempts to re-skin admin: it breaks legacy custom pages. AFAIK the admin never promised an "API" (if we can call html that), at the time 1.4 broke most of my custom admin templat

Re: Changes to django.db.models.fields.Field API

2015-03-04 Thread Thomas Stephenson
Colin, Thanks for your input. I was intending on rolling these changes into my composite fields work, since it would give a better illustration of why the changes were useful, but I can create a separate PR with the changes. `get/set_instance_value` are perfectly valid names and I agree, slightly

Re: Composite fields

2015-03-04 Thread Thomas Stephenson
Thanks for that info. Just to be clear, I'm not interested in SoC grants or mentoring, I'm mostly writing this stuff for my own concerns (aimed at improving our internal use of django by contributing changes we want to see upstream). I've fought hard with management to be in a position to devote

Re: Changes to django.db.models.fields.Field API

2015-03-04 Thread Collin Anderson
Hi, If it's not too much work, creating pull requests could help give some context and show a bit more of the impact of your proposed changes. Some days I think I'm better at reading Python than English :) value_from_object maybe should be value_from_instance or get_instance_value, as in, pick

Re: Composite fields

2015-03-04 Thread Loïc Bistuer
Hi Thomas, fields/related.py is begging for a refactor of the existing relational fields, and ideally we'd build composite fields on top of this refactor. The ORM has seen huge changes in the recent past: migrations, expressions, lookups, and last but not least a *public* footprint in Model._

Re: Composite fields

2015-03-04 Thread Thomas Stephenson
> Have you thought about how CompositeFields and SubFields will interact with migrations? I've given it some though, but at the moment I've just hacked out the one point in the code where it makes a difference, marked it with a FIXME and was going to return to it after I could store and query valu

Re: Suggestion: add default "registration/login.html" to django.contrib.auth

2015-03-04 Thread Collin Anderson
Could be as simple as: {% csrf_token %}{{ form }} On Tuesday, March 3, 2015 at 9:32:48 AM UTC-5, Ilya Kazakevich wrote: > > I agree: adding template from example is good idea! And I believe it will > be used at least by newbies who just study Django auth system and by people > who just need prot

Re: Django Admin new look

2015-03-04 Thread Collin Anderson
Re theming layer: In theory (if you use collectstatic :) it should be possible to include an "app" that overrides the css files. I believe it the custom app would need to be placed above django.contrib.admin in INSTALLED_APPS. Or you can even override the files by putting them in a STATICFILES_

Re: Composite fields

2015-03-04 Thread Josh Smeaton
With regards to the field API - that probably doesn't need an ML discussion. Open a ticket on Trac, submit a PR, and the people that will want to see it will review it. If there's confusion about how to proceed, then an ML discussion can be had, when there are actually interested parties involv

Re: Composite fields

2015-03-04 Thread Michael Manfre
As the others have already stated, patience is required if you want meaningful feedback. Have you thought about how CompositeFields and SubFields will interact with migrations? Regards, Michael Manfre On Wed, Mar 4, 2015 at 8:16 AM, Thomas Stephenson wrote: > Considering the past two proposals

Re: Composite fields

2015-03-04 Thread Thomas Stephenson
Hey there, Yeah, I've looked through some (probably not all) of the previous proposals to support composite fields. I was going to wait until some more work had been done to split concrete fields from virtual fields (ticket 16508 ), because I thought th

Re: Composite fields

2015-03-04 Thread Josh Smeaton
Hey Thomas, You've only waited 11 hours for a response here. Your contributions are definitely welcome, and it's obvious that you've done a lot of work and put in a lot of effort. Personally, I thank you. The reason you're not getting a response, at this point, is because the number of people

Re: Composite fields

2015-03-04 Thread Curtis Maloney
Have you reviewed all the existing works on trying to add composite fields? I know several managed to reach a level of maturity that was almost merge quality, and am sure I heard some of the recent ORM changes would ease support. On 5 March 2015 at 11:42, Thomas Stephenson wrote: > OK, no need

Re: Composite fields

2015-03-04 Thread Thomas Stephenson
OK, no need for everyone to shout -- your message is heard loud and clear. I'll go and find something else to work on. On 5 March 2015 at 00:16, Thomas Stephenson wrote: > Considering the past two proposals I've made here, I doubt I'll get more > than an echo chamber effect on this one. > > For t

Re: Django Admin new look

2015-03-04 Thread Curtis Maloney
Looks pretty slick, but brings with it all the hassles of the past attempts to re-skin admin: it breaks legacy custom pages. I wish we could standardise a theming layer for admin... allow legacy templates, or switching to new, clean, themable templates... Perhaps this could be integrated with the

Re: Django Admin New Look

2015-03-04 Thread Riccardo Magliocchetti
Il 04/03/2015 21:56, elky ha scritto: Quick summary of the PR discussion : * Everyone (ok, probably not) understands that current admin interface looks old * Green theme I used from djangoproject site isn't good idea - admin shouldn't be assoc

Re: Django Admin New Look

2015-03-04 Thread elky
Quick summary of the PR discussion : - Everyone (ok, probably not) understands that current admin interface looks old - Green theme I used from djangoproject site isn't good idea - admin shouldn't be associated with brand - It's better

Re: permissions and groups data migration

2015-03-04 Thread Andrew Grigorev
Thank you, Luis-José Torres! On the basis of your code I added the following to my migrations: def fix_perms(*app_labels): def wrapped(apps, schema_editor): from django.apps.registry import apps from django.contrib.contenttypes.management import update_contenttypes fr

Django Admin New Look

2015-03-04 Thread Alexey
Hi guys, I think django admin needs new look. I played with styles recently and that's the result: https://github.com/django/django/pull/4232 Inspired by a new djangoproject.com site. New theme looks modern, fresh and clean. There are CSS changes only. No any HTML changes. Let's discuss it. I w

Place on a server

2015-03-04 Thread Ch. APPerone
Who can help me to place www.demoafspraaktotaal.nl on the server We have problems with de dependencies!! -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving em

Composite fields

2015-03-04 Thread Thomas Stephenson
Considering the past two proposals I've made here, I doubt I'll get more than an echo chamber effect on this one. For the past week or so I've spent a bit of time on a feature I've always wanted to see land in django -- composite fields. The tickets have been open in the bug tracker for quite s