Re: automated import sorting and better pull request checks

Hi Tim, I've always found pylint a pleasure to work with. It may be worth looking into if we want additional automated testing. Pylint has great set of code checks (unused variable, unused import, trailing whitespace, bad indentation, etc.) and can integrate with Jenkin

Re: Formalizing template loader and debug api's

Hi Aymeric, It took me awhile, but I haz an update: https://github.com/django/django/pull/3475 Loader cleanup This addresses the code duplication between get_internal and load_template_sources. I also made the app directories loader inherit from the filesystem loader, since the only real differ

Re: automated import sorting and better pull request checks

I personally prefer multi_line_output = 4 (closing parentheses on the same line), but no big deal either way. On Thursday, January 29, 2015 at 10:56:03 AM UTC-5, Tim Graham wrote: > > Here's the current iteration of the config (it's stored in setup.cfg). > > [isort] > combine_as_imports = true >

Re: automated import sorting and better pull request checks

Here's the current iteration of the config (it's stored in setup.cfg). [isort] combine_as_imports = true known_first_party = django multi_line_output = 5 skip = build,.git On Thursday, January 29, 2015 at 9:39:04 AM UTC-5, Aymeric Augustin wrote: > > Hi Tim, > > Good idea. There are so many chang

Re: automated import sorting and better pull request checks

Hi Tim, Good idea. There are so many changes on PR 4009 that I couldn't check if you wrote a .isort.cfg. Did you, or are you just using the defaults? -- Aymeric. 2015-01-29 14:18 GMT+01:00 Tim Graham : > As a code reviewer, I've really appreciated that we've cleaned up the code > using flake8

Re: automated import sorting and better pull request checks

Hi Tim / all, I've been running a "linting as a service" for a while now called Landscape - https://landscape.io . It runs pep8, pyflakes and mccabe as well as pylint and some other things (such as pyroma and pep257 optionally). You then get a report of the errors found as well as diffs since t

Re: automated import sorting and better pull request checks

Would it be possible to use travis for flake8/docs checks? That would hopefully automatically show up as two separate flags on the status API. Of course it would be really nice if the docs and flake8/isort and tests all displayed separately. An alternative could be to use code climate which curren

Re: Multiple template engines for Django - retrospective

Good series of post, and great work. Thank you On 01/25/2015 11:29 PM, Aymeric Augustin wrote: Hello, Here’s the final weekly update for this project: https://myks.org/en/multiple-template-engines-for-django/#2015-01-25 Huge thanks for everyone who helped me along the way! -- You received t

automated import sorting and better pull request checks

As a code reviewer, I've really appreciated that we've cleaned up the code using flake8 and have automated "enforcement" via the CI server. I'd like to extend the idea to apply to standardizing import ordering using isort [1]. This mail is to advise everyone of the change and to address any con