Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-07 Thread Aymeric Augustin
Hi Preston, On 7 nov. 2014, at 18:51, Preston Timmons wrote: > First, if multiple engines are configured, how do you see the error being > displayed if a template isn't found in any of them? Currently, this > originates from the template loaders. For instance, the filesystem loader > raises a

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-07 Thread Preston Timmons
Aymeric, Great work on this. I have a few more questions: First, if multiple engines are configured, how do you see the error being displayed if a template isn't found in any of them? Currently, this originates from the template loaders. For instance, the filesystem loader raises a TemplateDoe

Re: Cleaning up broken pipe errors in runserver

2014-11-07 Thread Tim Graham
An opinion from Emil Stenström posted on the pull request (I'm inclined to agree with it unless there are objections or if someone can propose another solution): I agree that we should use the latest version of handle() from CPython to make sure we are as protected as we can be, even when usi

Re: Why doesn't ModelChoiceField.queryset support slicing?

2014-11-07 Thread Kamil Śliwak
> > However, I don't think this is subject to the kind of problem you describe > as the inner queryset should be turned into a subquery of the main queryset. Yes, I can confirm that I used this solution and it returns a QuerySet. It does not perform query at module load time in my case. It's

Re: Why doesn't ModelChoiceField.queryset support slicing?

2014-11-07 Thread Thomas
It's true that the generated queries might be inefficient (I'm not sure all DBMS can optimize something like "*SELECT ... FROM foo WHERE id IN (SELECT id FROM foo ORDER BY bar LIMIT 10)*"). I would not use such a construction on a big production dataset and if performance really matters I would