Re: Proposal: Write unit tests for JavaScript

Hi Nick, Personally, I think this is a great start. I would like to hear input from others. I appreciate the work you put into manually resolving those jshint warnings. The qunit test style looks good to me too. I added some comments on the pull request with some suggestions for improvements.

Re: Can we use a django application class?

Hi Robert, I don't know if you've noticed, but your message is a reply to a 7 year old thread. A lot of things have changed in the meantime - not the least of which is the fact that Django 1.7 introduced an AppConfig object. See the 1.7 release notes and the documentation on the AppConfig object f

Re: Proposal: Write unit tests for JavaScript

So, I have been working a little on a PR for this ( https://github.com/django/django/pull/3003) and having spoken to Tim briefly about getting this supported in jenkins I just wanted to check that the approach was OK. The tests use node, grunt, qunit, istanbul and jshint. Is this a reasonable appro

Re: Pull django-registration into contrib?

Speaking for myself, I am still willing to hand over the reins of django-registration to someone who's genuinely motivated to try to solve the issues surrounding things like custom User support, etc., though I still do believe that's just a bridge too far for what was meant to be a simple app. I'v

Re: Pull django-registration into contrib?

On August 1, 2014 at 10:28:22 AM, Robert Grant (robertlagr...@gmail.com) wrote: > Hi Tim > > I did. I just reread it though; thanks for the link. There are multiple > ways to do registration, agreed, but then one could - for example - make > your same argument about logging into a system. Why pr

Re: Updating the organization of the Django Project

> Christian, have you seen the patch review checklist I put together? Yep and I will definitely do some more work in the future. Everything i write now is my personal opinion. first of all trac has some of the weakest Query Filters. (thats my personal opinion) the next thing is that changing the

Re: Pull django-registration into contrib?

What no one is discussing here is is that django-registration is just one out of several popular authentication backends that match it for use and great exceed it's functionality. They include: * django-allauth * django-userena * python-social-auth (nee django-social-auth) These three projects

Re: SchemaEditor + DatabaseConnection

At the moment you'll need to make sure both Creation and SchemaEditor do the right thing for stuff like that. We bumped "deprecate DatabaseCreation" back to 2.0 for a final removal as it was so complex and so much stuff relies on it (including SchemaEditor in places where I didn't want to duplicate

Re: Updating the organization of the Django Project

Christian, have you seen the patch review checklist I put together? https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist That is basically what I do when I review a patch. If a patch meets those guidelines, please mark it RFC. A co

Re: Updating the organization of the Django Project

its a matter of trust. gerrit tracks your reviews so its way easier to build up trust that the things you mark as RFC is really RFC ;) And yes its a matter of tooling since some tools provide a better way to build trust for such community processes. Also I'm quite young. I wouldn't want to make a "

Re: Updating the organization of the Django Project

Hi Christian, On 08/01/2014 01:37 PM, Schmitt, Christian wrote: [snip] > i mean maybe we should really look at a review tool and maybe say if two > people of the community reviewed it gets pipelined to the "core" which > can do a final review. so it would be more community oriented and fewer > "ba

Re: Updating the organization of the Django Project

i know that such things drains a lot of energy. I'm working for a very small company and we changed our commit / review system entirely. currently I think you are right at your four points, but one of your four points is somehow really bad > We have only one person reviewing patches regularly in

i18n json catalog

Hi all, I would like to contribute with this feature, you can see the proposal in #22404 . If you agree with the idea I could start writing the documentation. Regards, Manolo Ramirez T. -- You received this message because you are subscribed to the

Re: Updating the organization of the Django Project

On 1 août 2014, at 18:31, Christian Schmitt wrote: > Since you've introduced these changes, wouldn't it be suitable to change > Django's commit / review system entirely? "Hey, you climbed this hill just fine, why don't you climb the Everest while you're at it?" ;-) Even though the final vote l

Re: Updating the organization of the Django Project

> > Also there are like 120 Pull Requests which are over an year old > sometimes.Which scary's off a lot of people. We should do something against > it to have a "cleaner" queue. > In theory every pull request has a trac ticket and the queue is all handled by queries such as: https://code.djang

Re: Updating the organization of the Django Project

Since you've introduced these changes, wouldn't it be suitable to change Django's commit / review system entirely? Like introduce gerrit, where very commit / ticket needs to be reviewed by X people and then it would be marked as merge ready and a "core" or whoever member could merge that. There

Re: Pull django-registration into contrib?

It seems to me, in any case, the first step is to get django-registration actively maintained again. James Bennett is welcoming proposals of people to take over maintenance of the project. Get it working well with custom user models and with python 3. Once django-registration is a thriving app

Re: Proposal new Django Admin css style

The main idea is to maintain compatibility with the current template, changing only css. I changed the css and replace images icons to fonts. On Fri, Aug 1, 2014 at 1:06 PM, Daniele Faraglia wrote: > wonderful idea, > > maybe css should be compiled by less/sass files? > > > 2014-08-01 17:37 GMT

Re: Proposal new Django Admin css style

wonderful idea, maybe css should be compiled by less/sass files? 2014-08-01 17:37 GMT+02:00 Qing Feng : > I like this style +1 > > > 2014-08-01 21:46 GMT+08:00 Thiago Avelino : > > Hi guys! Django admin has a few years, it works fine (meets the need) only >> need to evolve the style following t

Re: Proposal new Django Admin css style

I like this style +1 2014-08-01 21:46 GMT+08:00 Thiago Avelino : > Hi guys! Django admin has a few years, it works fine (meets the need) only > need to evolve the style following the evolution of UX today! > > We have a plan for change? > > What do you think of this style ​ > https://github.com/

Re: Proposal new Django Admin css style

I like that it's all done without changing the html. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post

Re: Pull django-registration into contrib?

Hi, Robert, I just wanted to say that I'm +9000 in favor of your proposal. In fact, I think Django as a whole can benefit from the kind of reasoning behind your argument. Having key strengths is what drives adoption from new users, and that should be any framework's concern. I strongly feel that t

Re: Proposal new Django Admin css style

I really like this style. Clean and modern! Cheers -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post

Re: Pull django-registration into contrib?

Hi Tim I did. I just reread it though; thanks for the link. There are multiple ways to do registration, agreed, but then one could - for example - make your same argument about logging into a system. Why provide that when some people might not want a site with authentication, or might want to d

Proposal new Django Admin css style

Hi guys! Django admin has a few years, it works fine (meets the need) only need to evolve the style following the evolution of UX today! We have a plan for change? What do you think of this style ​ https://github.com/hersonls/djamin#screenshots ? Is django admin html + custom css! Cheers, Thiag

Re: Updating the organization of the Django Project

Hello, Since the proposal was accepted with sixteen +1, I committed it: https://github.com/django/django/commit/8c2b405ba8343e68bc32ac2c860be0c6cfd7d631. The next step is to elect the first technical board, as soon as 1.7 final is released. As Tim noticed, team.txt and roles.txt are unrelated

Re: Pull django-registration into contrib?

Did you read the reasons that James decided to stop maintaining it? http://www.b-list.org/weblog/2013/aug/26/catching/ Any Django site that uses a database will benefit from integrating database migrations. On the other hand, there are many ways to do user registration (as James described in hi

Re: Pull django-registration into contrib?

Hi Tim Thanks for the reply. I'd say that it's only been viable so far because James created and maintained it (for most of that long time), it's only been a year since then and Django is pretty stable around users and authentication. And even then people have forked the thing to Github to cr

Re: querry to pass jquery variable value to django template, please responce me need help one of yours...

On Fri, Aug 1, 2014, Jaiprakash Singh wrote: >unfortunately, i am not able find the solution, so require some hints from >all of u guys You'll get answers to your questions on the django-users email list, - the web interface is . The l

querry to pass jquery variable value to django template, please responce me need help one of yours...

hello all, i am working on project for learning purpose, i have got stuck on a small logic , i have tried lot to find the solution , gone to url like http://www.sprklab.com/notes/13-passing-arguments-to-functions-in-django-template http://www.tangowithdjango.com/book/chapters/ajax.html

Re: Can we use a django application class?

Just had some thoughts about why having an application object might be a good idea. Pick away :) - Individual app objects could perhaps be introspected more easily, e.g. stop, start, restart functions provided for them. Also circular dependency detection etc, for impact analysis. -

Re: Pull django-registration into contrib?

If no one has volunteered to maintain it in nearly a year since James stepped down, I think you'll have a tough time convincing us it's important enough to move into contrib. Also, the recent trend has been to remove things from contrib (comments, localflavor, formtools soon). django-registrati

Pull django-registration into contrib?

Hello all I've just started using Django for a serious project and am really enjoying using it; thank you. I'm using Django 1.6 and Python 3.4. For user signups, everyone recommends using django-registration. However this is not under active development