Re: Improving aggregate support (#14030)

2013-12-23 Thread Josh Smeaton
So, after hacking away a little bit yesterday, I came to the same conclusion that Anssi did back when the first PR was sent. Namely, that the ExpressionNode <-> SQLEvaluator structure seems overly complex, and makes it difficult to create custom "ExpressionNodes". To build a custom Expression,

Re: Django 1.7 - Named migration directory

2013-12-23 Thread Val Neekman
How did I miss that. Excellent! Thanks. Val On Mon, Dec 23, 2013 at 7:08 PM, Andrew Godwin wrote: > There's already a setting for changing an app's migrations directory, > called MIGRATION_MODULES. The app can just instruct people who want to not > use PostGIS to set that to a different plac

Re: Django 1.7 - Named migration directory

2013-12-23 Thread Andrew Godwin
There's already a setting for changing an app's migrations directory, called MIGRATION_MODULES. The app can just instruct people who want to not use PostGIS to set that to a different place if they want to ship the app like that, achieving exactly the result you want without an extra setting per ap

Django 1.7 - Named migration directory

2013-12-23 Thread Val Neekman
I am wondering if it would be a good idea for a django app to name its migration directory and if nothing is provided then the name would default to 'migrations'. The case: (let's call it a GEO app) GEO app looks at the setting.py file for a flag called "GEO_USING_GEO_DJANGO". # in models.py if

Re: App-loading reloaded

2013-12-23 Thread Andrew Godwin
Thanks for your work on this, Aymeric - the reduced scope has really done well, I think. Couple of comments (I agree that generally the list of work is accurate): - There's already a MIGRATION_MODULES setting which lets you set the path to a migration module by app label. We probably just need t

Re: App-loading reloaded

2013-12-23 Thread Aymeric Augustin
The time frame I had allocated to this project expires tomorrow. With reference to my original list, I’ve reached goals 1, 2, 6 and 7, with the caveat that I still have to write documentation. I ran out of time before looking seriously at goal 3, but it appears to be within reach at this point.

Re: App-loading reloaded - custom app names in the admin

2013-12-23 Thread Aymeric Augustin
After the merge, some Selenium tests (which I don’t run locally in general) failed on Jenkins. That’s a test isolation issue: an AppDirectoriesFinder instance kept a cache of an incomplete list of applications, preventing later tests from finding static files correctly. I wanted to review the m