Re: RFC #9200 -- Refactored form wizard

2011-05-31 Thread Luke Plant
On 30/05/11 10:15, Jannis Leidel wrote: > Hi all, > > Stephan and me are now happy with the latest patch for ticket #9200 > which refactors the form wizard in the formtools contrib app to > use class based views and the new secure cookies as one of the > supported storage backends (a session backe

Re: RFC #9200 -- Refactored form wizard

2011-05-31 Thread Jacob Kaplan-Moss
On Tue, May 31, 2011 at 4:27 PM, Jannis Leidel wrote: > This is needed to load the default template > django/contrib/formtools/wizard/wizard_form.html. I could definitely > add a note about it in the installation steps but see no way around > it generally. Any other idea? Ah OK, I missed that. Ne

Re: RFC #9200 -- Refactored form wizard

2011-05-31 Thread Jannis Leidel
> All in all this is fine to go in as far as I'm concerned, but I do > have a few nitpicky things that'd be nice to fix: > > * There's a bunch of code in formtools/wizard/__init__.py (the legacy > wizard, right?). Generally I dislike having a bunch of code in > __init__.py and I thought we were ge

Re: RFC #9200 -- Refactored form wizard

2011-05-31 Thread Jacob Kaplan-Moss
Hi Jannis -- Great work - thanks to both you and Stephan! All in all this is fine to go in as far as I'm concerned, but I do have a few nitpicky things that'd be nice to fix: * There's a bunch of code in formtools/wizard/__init__.py (the legacy wizard, right?). Generally I dislike having a bunch

#16110: deprecating arguments for a bugfix?

2011-05-31 Thread Paul Winkler
Assuming that my patch for https://code.djangoproject.com/ticket/16110 were to go in, it would deprecate an argument. The patch as it exists removes the only code that checks the 'null' keyword arg to contrib/ gis/forms/fields.py:GeometryField.__init__(). That keyword arg was, AFAICT, a mistake an

Re: Changeset 16297

2011-05-31 Thread Alex Gaynor
On Tue, May 31, 2011 at 8:26 AM, Luke Plant wrote: > On 31/05/11 14:55, Alex Gaynor wrote: > > > I came up with an alternate approach that is much > > simpler: http://paste.pocoo.org/show/398303/ , all tests pass with this. > > Any objections to checking this in? > > This is much better than my

Re: Changeset 16297

2011-05-31 Thread Luke Plant
On 31/05/11 14:55, Alex Gaynor wrote: > I came up with an alternate approach that is much > simpler: http://paste.pocoo.org/show/398303/ , all tests pass with this. > Any objections to checking this in? This is much better than my attempt, but I spotted some problems. This line seems to have a b

Re: Changeset 16297

2011-05-31 Thread Alex Gaynor
On Tue, May 31, 2011 at 3:39 AM, Luke Plant wrote: > On 31/05/11 00:26, Alex Gaynor wrote: > > Hi all, > > > > I'm looking at r16297 (https://code.djangoproject.com/changeset/16297), > > and I don't like this approach, I understand what it is trying to > > accomplish, but it has several downsides

Timezone-aware storage of DateTime

2011-05-31 Thread Daniel Swarbrick
I can almost hear the collective sigh as this topic once again rears up ;-) I am currently developing an app with Django that uses the SQLite backend, and I noticed that Django stores DateTime fields as naive (eg. non TZ-aware), local timestamps, making these databases non- portable to servers run

Re: Changeset 16297

2011-05-31 Thread Luke Plant
On 31/05/11 00:26, Alex Gaynor wrote: > Hi all, > > I'm looking at r16297 (https://code.djangoproject.com/changeset/16297), > and I don't like this approach, I understand what it is trying to > accomplish, but it has several downsides that don't appear to have been > considered: > > a) On CPython