Re: Issue 14878 And Changeset 15133

2011-01-06 Thread Gert Van Gool
Not really related to #5373, since it's related to the new generic views code. -- Gert Mobile: +32 498725202 Twitter: @gvangool Web: http://gert.selentic.net On Fri, Jan 7, 2011 at 00:26, Lachlan Musicman wrote: > > 2011/1/7 Diego Andrés Sanabria Martín : > > A few weeks ago i report this issu

User model being included by default

2011-01-06 Thread Antony Vennard
Hello all, For various reasons a client of mine requested that, other than using a framework of their choice, I implement an authentication system following their spec. I used Django and implemented my own app which contains the usual models.py which implements a user object and so on. Django has

Re: SQL join promotion as a result of querying for a NULL value

2011-01-06 Thread Byron Ruth
> Just to be clear: The assumption is that if: >         1) the user filtered on a related model's field >         2) with is_null=True, and >         3) there is a nullable FK in the chain leading to the filtered field >            (this is checked by promote_alias_chain), > then: > use a left out

Re: Regressions in 1.2.4

2011-01-06 Thread Luke Plant
FWIW, I'm inclined to agree with James and Gabriel that having security only releases on the bugfix branch will increase confusion, and will increase the likelihood that human error with regards to packages (both by the Django team and by Django users) is the cause of both more security problems an

Re: SQL join promotion as a result of querying for a NULL value

2011-01-06 Thread Shai Berger
On Thursday 06 January 2011, Byron Ruth wrote: > I am speaking of this particular if statement: > http://code.djangoproject.com/browser/django/tags/releases/1.2.4/django/db/ > models/sql/query.py#L1051 > > There are a few implications of this assumption. Just to be clear: The assumption is that i

Re: Issue 14878 And Changeset 15133

2011-01-06 Thread Lachlan Musicman
2011/1/7 Diego Andrés Sanabria Martín : > A few weeks ago i report this issue, 14878[1], and Rusell fix it, but > i think still there is a possible bug, if the verbose name of a model > includes a translation string. Is this related to http://code.djangoproject.com/ticket/5373 ? cheers L. -- "

Re: SQL join promotion as a result of querying for a NULL value

2011-01-06 Thread Philippe Raoult
I too was rather surprised by this behavior. I have since changed my code to use exclude(related__field__isnull = False) instead of filter(related__field__isnull = True) to avoid this issue. I'm all for an API, but I'm not sure which would be best. Maybe filter(related__field__isnull_nopromote = T

Re: contrib 's FormWizard needs a lot of work

2011-01-06 Thread David Durham
On Thu, Jan 6, 2011 at 4:22 PM, Stephan Jäkel wrote: > Hi David, > > you should take a look at the NamedUrlFormWizard. In this second approach, > after successful posting a form, a redirect is done to get the user to the > next step. Is this the point you meant? > > Using the NamedUrlFormWizard, i

Re: contrib 's FormWizard needs a lot of work

2011-01-06 Thread Stephan Jäkel
Hi David, you should take a look at the NamedUrlFormWizard. In this second approach, after successful posting a form, a redirect is done to get the user to the next step. Is this the point you meant? Using the NamedUrlFormWizard, it's also possible to display links to different steps. Chee

SQL join promotion as a result of querying for a NULL value

2011-01-06 Thread Byron Ruth
I am speaking of this particular if statement: http://code.djangoproject.com/browser/django/tags/releases/1.2.4/django/db/models/sql/query.py#L1051 There are a few implications of this assumption. One being, that if the user is actually trying to get the "real" rows that exist with a column that h

Re: Regressions in 1.2.4

2011-01-06 Thread Gabriel Hurley
On Thursday, January 6, 2011 6:29:32 AM UTC-8, James Bennett wrote: > > It'd also be a major > maintenance/bookkeeping headache and, I think, *more* likely to result > in us accidentally crossing the streams while trying to keep track of > what goes on in which branch. > I have the same concern her

Re: contrib 's FormWizard needs a lot of work

2011-01-06 Thread David Durham
If I'm reading this code correctly: https://github.com/stephrdev/django-formwizard/blob/master/formwizard/forms.py I think this implementation misses the core point I was trying to address with #9200, that you should not have to POST in order to navigate to a step/form in the wizard. My implem

Re: app loading

2011-01-06 Thread Alex Kamedov
Hello Arthur, thanks for good work on this branch. I've knew about APP_CLASSES on starting the topic, but I not understood why it was not merged with INSTALLED_APPS. Thank you for explanation. Now I see. I found some problems with contrib applications and managment commands and can produce patch

Issue 14878 And Changeset 15133

2011-01-06 Thread Diego Andrés Sanabria Martín
A few weeks ago i report this issue, 14878[1], and Rusell fix it, but i think still there is a possible bug, if the verbose name of a model includes a translation string. [1] http://code.djangoproject.com/ticket/14878 [2] http://code.djangoproject.com/changeset/15133 -- You received this message

Re: Regressions in 1.2.4

2011-01-06 Thread James Bennett
On Wed, Jan 5, 2011 at 10:05 AM, Russell Keith-Magee wrote: > We will obviously to do a 1.2.5 release when we hit 1.3 final; but I'm > not sure if we should push an 1.2.5 (and 1.1.4) ASAP addressing these > regressions, and then do 1.2.6 when we cut 1.3 final. I'm in favor of doing 1.2.5 as soon

Re: Regressions in 1.2.4

2011-01-06 Thread Ramiro Morales
On Wed, Jan 5, 2011 at 1:05 PM, Russell Keith-Magee wrote: > > We will obviously to do a 1.2.5 release when we hit 1.3 final; but I'm > not sure if we should push an 1.2.5 (and 1.1.4) ASAP addressing these > regressions, and then do 1.2.6 when we cut 1.3 final. > > This also points out that we sho

Re: Regressions in 1.2.4

2011-01-06 Thread Karen Tracey
On Wed, Jan 5, 2011 at 11:05 AM, Russell Keith-Magee < russ...@keith-magee.com> wrote: > This also points out that we should perhaps reconsider our release > policy. Putting out security releases that include unrelated fixes is > a bit of a risk. We've been bitten by this in the past, but never th

Re: i18n bug in template rendering.

2011-01-06 Thread Jonathan S
Thanks Ramiro, we hope the patch will be applied in the next release. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to dj

Re: i18n bug in template rendering.

2011-01-06 Thread Ramiro Morales
On Thu, Jan 6, 2011 at 8:15 AM, Ramiro Morales wrote: > Weird, it's working here: Ignore me, I was creating a new Template instance. I can reproduce it: In [1]: from django.utils import translation In [2]: from django.template import Template, Context In [3]: In [4]: In [5]: def language(

Re: i18n bug in template rendering.

2011-01-06 Thread Ramiro Morales
On Thu, Jan 6, 2011 at 5:07 AM, Jonathan S wrote: > >> You aren't supposed to use _('Foo') as a standalone variable. >> (see last paragraph >> herehttp://docs.djangoproject.com/en/1.2/topics/i18n/internationalization...) > > > Why shouldn't I use it as a standalone variable? (A language should >

Re: ImageField documentation clarification

2011-01-06 Thread Russell Keith-Magee
On Thu, Jan 6, 2011 at 6:06 PM, James Hancock wrote: > I am very new to Django, and so I spend a lot of time in the documentation. > The other day I found something that I wished would have some more > clarification in retrospect, so I thought I would post it here. > > > My goal was to have the ad

ImageField documentation clarification

2011-01-06 Thread James Hancock
I am very new to Django, and so I spend a lot of time in the documentation. The other day I found something that I wished would have some more clarification in retrospect, so I thought I would post it here. My goal was to have the admin resize an image for me on upload to a standard size. While

Re: i18n bug in template rendering.

2011-01-06 Thread Jonathan S
> You aren't supposed to use _('Foo') as a standalone variable. > (see last paragraph > herehttp://docs.djangoproject.com/en/1.2/topics/i18n/internationalization...) Why shouldn't I use it as a standalone variable? (A language should have a *context free* grammar, which means, that the undersco