Re: rethinking raw_id_fields

2010-10-03 Thread subs...@gmail.com
With the AJAX field implementation on the table you're free to represent the objects however you want. Yeah, there's a few things left out but did you really say 'no searching'? -Steve On Oct 3, 10:09 pm, Chuck Harmston wrote: > it's based on the assumption that the user knows the value of the u

Re: Contributing more

2010-10-03 Thread Russell Keith-Magee
On Mon, Oct 4, 2010 at 10:11 AM, Laurent Luce wrote: > Hello, > > I added the localflavor for Belgium as my first contribution. I would > like to contribute more code wise. I looked at the tickets with > milestone 1.3 and with no patch. It is hard to know what is critical > and where help is the m

Proposal: PositiveBigIntegerField

2010-10-03 Thread Yo-Yo Ma
Positive integer fields are useful all the time, and BigIntegerField is no exception to that. On a side note, there doesn't appear to be any built-in model-field level protection from putting gigantic numbers into an IntegerField. When using IntegerField in dev (sqllite3) it allows me to put somet

Re: Contributing more

2010-10-03 Thread Eric Holscher
Hey Laurent, Glad to hear you want to help out! The first step that I usually take is figuring out what component I want to work on. This is usually based around what I have the most familiarity with, or what part I'm interested in learning more about. Trac has nice features for filtering down by

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread André Eriksson
I should add.. The bonus of using class-based decorators is that decorated views can be subclassed. All other functionality is retained. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@

Re: Contributing more

2010-10-03 Thread David P. Novakovic
Hey, I've been working on tickets that don't have tests or patches or both, to help move them along :) I've found it a good way to get involved with things that aren't too contentious. There are a few documentation bugs as well. Others will certainly have their own take on it too... David On

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread André Eriksson
On Oct 3, 1:02 pm, Russell Keith-Magee wrote: > On Sun, Oct 3, 2010 at 12:12 PM, Ian Lewis wrote: > > On Sun, Oct 3, 2010 at 11:20 AM, Russell Keith-Magee > > wrote: > > While I'm in the "one singleton view instance is best" camp and think > > that storing some state on the request and some on

Contributing more

2010-10-03 Thread Laurent Luce
Hello, I added the localflavor for Belgium as my first contribution. I would like to contribute more code wise. I looked at the tickets with milestone 1.3 and with no patch. It is hard to know what is critical and where help is the most needed. Can someone tell me what tickets require immediate h

Re: rethinking raw_id_fields

2010-10-03 Thread Chuck Harmston
An Ajax admin solution (of the autocomplete sort, which I presume is what you're proposing) does not have the same use case for raw_id_fields. It's based on the assumption that the user knows the value of the unicode representation of the object. It does not allow for discovery like the raw_id_fiel

Re: rethinking raw_id_fields

2010-10-03 Thread subs...@gmail.com
Does anyone besides me think that an AJAX field admin solution effectively deprecates raw_id_fields? I'm interested in seeing a ticket like #14370 go forward if only to close a slew of dusty old tickets about raw_id_fields. -Steve On Oct 3, 5:58 am, Marcob wrote: > Well, M2M and raw_id_fields a

Re: variable view name in url tag

2010-10-03 Thread Russell Keith-Magee
On Mon, Oct 4, 2010 at 8:56 AM, Sean Brant wrote: > > On Oct 3, 2010, at 7:37 PM, Russell Keith-Magee wrote: > >> On Mon, Oct 4, 2010 at 4:53 AM, Sean Brant wrote: >>> I know this has come up over the last few years[1] and people are >>> mixed on the action that should be taken. I would like to b

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread André Eriksson
On Oct 3, 1:02 pm, Russell Keith-Magee wrote: > On Sun, Oct 3, 2010 at 12:12 PM, Ian Lewis wrote: > > On Sun, Oct 3, 2010 at 11:20 AM, Russell Keith-Magee > > wrote: > > While I'm in the "one singleton view instance is best" camp and think > > that storing some state on the request and some on

Re: Proposal: Meta.required_together

2010-10-03 Thread LookMa NoSQL
Tino, are you joking? Did you even bother to read the OP's proposal. I think there is a real lack of patience when you spend the time writing what the OP has written without even reading it, just to try to dismiss it. OP: >def clean(self): >if any((self.weight, self.height)) >if not a

Re: variable view name in url tag

2010-10-03 Thread Sean Brant
On Oct 3, 2010, at 7:37 PM, Russell Keith-Magee wrote: > On Mon, Oct 4, 2010 at 4:53 AM, Sean Brant wrote: >> I know this has come up over the last few years[1] and people are >> mixed on the action that should be taken. I would like to bring it up >> again as it has bitten me a few time lately.

Re: variable view name in url tag

2010-10-03 Thread Russell Keith-Magee
On Mon, Oct 4, 2010 at 4:53 AM, Sean Brant wrote: > I know this has come up over the last few years[1] and people are > mixed on the action that should be taken. I would like to bring it up > again as it has bitten me a few time lately. > > I seems the biggest concern is backwards compatibility of

Re: be localflavor Belgium

2010-10-03 Thread Russell Keith-Magee
2010/10/4 Łukasz Rekucki : > On 3 October 2010 20:53, Laurent Luce wrote: >> Am I supposed to commit the patch? I don't think I have the privileges >> to do that. > > No, only core developers can commit changes. The patch is marked RFC > and has milestone 1.3, so it's pretty sure it won't be forgo

variable view name in url tag

2010-10-03 Thread Sean Brant
I know this has come up over the last few years[1] and people are mixed on the action that should be taken. I would like to bring it up again as it has bitten me a few time lately. I seems the biggest concern is backwards compatibility of the syntax. I feel that should not stop us from fixing some

Re: Proposal: Meta.required_together

2010-10-03 Thread TiNo
Doesn't this do what you want?: class MyModel(models.Model): weight = .. height = ... width = ... length = ... def clean(self): from django.core.exceptions import ValidationError if self.weight or self.height or self.width or self.length and not

Re: be localflavor Belgium

2010-10-03 Thread Łukasz Rekucki
On 3 October 2010 20:53, Laurent Luce wrote: > Am I supposed to commit the patch? I don't think I have the privileges > to do that. No, only core developers can commit changes. The patch is marked RFC and has milestone 1.3, so it's pretty sure it won't be forgotten. I suspect that because Russel

Re: be localflavor Belgium

2010-10-03 Thread Laurent Luce
Am I supposed to commit the patch? I don't think I have the privileges to do that. Laurent On Sep 30, 5:35 pm, Russell Keith-Magee wrote: > On Fri, Oct 1, 2010 at 6:15 AM, Laurent Luce wrote: > > I updated the be localflavor patch to use unit tests instead of > > doctests as requested. Can you

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Ian Lewis
On Sun, Oct 3, 2010 at 8:02 PM, Russell Keith-Magee wrote: >> Other frameworks seem have View/Handler instances per request, such as >> appengine's webapp so there is some precedent for creating an instance >> per request. >> >> http://code.google.com/appengine/docs/python/gettingstarted/handlingf

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Ian Lewis
2010/10/3 Łukasz Rekucki : > On 3 October 2010 06:12, Ian Lewis wrote: >> Flask seems to do it the callable singleton way: >> >> http://flask.pocoo.org/docs/patterns/lazyloading/ >> > I never used Flask, so I might be missing something, but I don't see a > singleton view instance here - just a pro

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread George Sakkis
On Oct 3, 4:20 am, Russell Keith-Magee wrote: > On Sat, Oct 2, 2010 at 8:01 PM, Carl Meyer wrote: > >> We could even wrap the "no args to __init__" error check in a method > >> that enables it to be overridden and silenced in a subclass; that way, > >> introducing the potentially un-threadsafe be

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread George Sakkis
On Oct 3, 6:12 am, Ian Lewis wrote: > Other frameworks seem have View/Handler instances per request, such as > appengine's webapp so there is some precedent for creating an instance > per request. > > http://code.google.com/appengine/docs/python/gettingstarted/handlingf... > > Flask seems to do i

Re: #6903 -- Go back to old change_list view after hitting save

2010-10-03 Thread Russell Keith-Magee
On Sun, Oct 3, 2010 at 6:09 PM, Marcob wrote: > I think that #6903 ticket http://code.djangoproject.com/ticket/6903 > (together with http://code.djangoproject.com/ticket/12241) should be > considered to be in 1.3 release. > Every single person I know that use admin without this patch asks for > th

Re: rethinking raw_id_fields

2010-10-03 Thread Russell Keith-Magee
On Sun, Oct 3, 2010 at 5:58 PM, Marcob wrote: > On 30 Set, 07:34, "subs...@gmail.com" wrote: >> Hello all, >> I was browsing the tickets and saw a few of them nagging about some >> restrictions to raw_id_fields. > > Since my first Django installation, a couple of years ago, I fixed and > used thi

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Russell Keith-Magee
On Sun, Oct 3, 2010 at 12:12 PM, Ian Lewis wrote: > On Sun, Oct 3, 2010 at 11:20 AM, Russell Keith-Magee > wrote: > While I'm in the "one singleton view instance is best" camp and think > that storing some state on the request and some on the view is a bit > gross, I understand Russell's argument

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Russell Keith-Magee
2010/10/3 Łukasz Rekucki : > On 3 October 2010 04:44, Russell Keith-Magee wrote: >> 2010/10/3 Łukasz Rekucki : > def with_args(view_cls, **kwargs): >    return type(view_cls.__name__, (view_cls,), kwargs) > > # in urls.py: > >  (r'^somepath', with_args(MyView, option=False

#6903 -- Go back to old change_list view after hitting save

2010-10-03 Thread Marcob
I think that #6903 ticket http://code.djangoproject.com/ticket/6903 (together with http://code.djangoproject.com/ticket/12241) should be considered to be in 1.3 release. Every single person I know that use admin without this patch asks for this functionality. On 3/23/2009 Jacob said: This has gone

Re: rethinking raw_id_fields

2010-10-03 Thread Marcob
On 30 Set, 07:34, "subs...@gmail.com" wrote: > Hello all, > I was browsing the tickets and saw a few of them nagging about some > restrictions to raw_id_fields. Since my first Django installation, a couple of years ago, I fixed and used this patch: http://code.djangoproject.com/ticket/7028 I see

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Waldemar Kornewald
Hi, first of all, I'd like to say that I fully agree that the final solution has to be thread-safe and has to support storing state on self. On Oct 2, 12:32 pm, Russell Keith-Magee wrote: > 2010/10/2 Łukasz Rekucki : > > Now you lost me. If we are discouraging people from using arguments to > > _

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Łukasz Rekucki
On 3 October 2010 06:12, Ian Lewis wrote: > Flask seems to do it the callable singleton way: > > http://flask.pocoo.org/docs/patterns/lazyloading/ > I never used Flask, so I might be missing something, but I don't see a singleton view instance here - just a proxy, that imports a function on first

Re: #6735 -- Class based generic views: call for comment

2010-10-03 Thread Łukasz Rekucki
On 3 October 2010 04:44, Russell Keith-Magee wrote: > 2010/10/3 Łukasz Rekucki : >> On 2 October 2010 12:32, Russell Keith-Magee wrote: >>> 2010/10/2 Łukasz Rekucki : On 2 October 2010 10:34, Russell Keith-Magee wrote: > >>   3) How do we make this shared settings immutable between re