Re: Session/cookie based messages (#4604)

2009-12-01 Thread SmileyChris
I applied and pushed all but your final whitespace revision. When Tobias reads this thread again, I'm sure he'll give you commit. The fail_silently sounds good, and yes these failures were a rather big oversight. On Dec 2, 10:35 am, Luke Plant wrote: > I've been going through the code carefully

Re: Single lines between top level classes & functions

2009-12-01 Thread Luke Plant
On Tuesday 01 December 2009 23:06:45 SmileyChris wrote: > Prompted by Luke's whitespace removal patch for django-contrib- > messages, I thought I'd bring this up. > > The Django contributing guide says "Unless otherwise specified, > follow PEP 8." > > Should new code use two lines between top le

Re: Single lines between top level classes & functions

2009-12-01 Thread Russell Keith-Magee
On Wed, Dec 2, 2009 at 7:06 AM, SmileyChris wrote: > Prompted by Luke's whitespace removal patch for django-contrib- > messages, I thought I'd bring this up. > > The Django contributing guide says "Unless otherwise specified, follow > PEP 8." > > Should new code use two lines between top level cla

Single lines between top level classes & functions

2009-12-01 Thread SmileyChris
Prompted by Luke's whitespace removal patch for django-contrib- messages, I thought I'd bring this up. The Django contributing guide says "Unless otherwise specified, follow PEP 8." Should new code use two lines between top level classes & functions, like PEP 8 suggests, or should the contributin

Re: Session/cookie based messages (#4604)

2009-12-01 Thread Luke Plant
On Monday 30 November 2009 15:18:03 Tobias McNulty wrote: > Your API suggestions sound fine; at least, as long as what messages > is doing import-wise isn't any worse than the rest of Django, it's > fine with me. :) > > Since this is a fairly significant change I would like to hear > feedback

Django development sprint in the Triangle, Dec 12-13

2009-12-01 Thread Tobias McNulty
Hi All, Just wanted to let you know that we'll be hosting a local Django Development sprint in the Triangle area of North Carolina next weekend (Dec 12 and 13). A development sprint is an excuse to get together, write some code, and have a good time doing it. The purpose of this sprint will be to

Re: Django Testing Environment

2009-12-01 Thread Tiago Samahá
I'm sorry Russell, i'll try to be more specific. So, i want to know how the test environment works when i run a suite test. How can i create and destroy a separated Django testing environment? I want to write a tool similar zope.testbrowser*, then i need to create a Django testing environment. I ha