Re: Last chance to object to new features

2009-11-03 Thread Waldemar Kornewald
On Tue, Nov 3, 2009 at 6:37 AM, Russell Keith-Magee wrote: > I've already integrated Jacob's comments into the code in my local > checkout. Actually, Jacob's comments pointed out an interesting code > cleanup: the File email backend is really just the Console email > backend pointing at a file ob

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Yuri Baburov
On Tue, Nov 3, 2009 at 11:37 PM, Adam V. wrote: > > I've been running with this patch applied, and it is a useful > debugging addition, color choice aside. Thanks. Of course, I will do something with current colors. I think the situation here is that new colors on familiar things always looks wei

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Adam V.
I've been running with this patch applied, and it is a useful debugging addition, color choice aside. One thing I ran into, though, is wanting to be able to assign colors to various 3rd party libraries that I'm also using. So for instance, giving MySQLdb it's own non-mine, non-Django color, so I

Re: Session/cookie based messages (#4604)

2009-11-03 Thread Jacob Kaplan-Moss
On Tue, Nov 3, 2009 at 12:27 PM, Waylan Limberg wrote: > I couldn't help but notice the docs suggest setting MESSAGE_STORAGE like so: > >    MESSAGE_STORAGE = 'cookie.CookieStorage' > > Just yesterday, in reference to another upcoming feature, Jacob > commented that he would prefer all such setti

Re: Session/cookie based messages (#4604)

2009-11-03 Thread Tobias McNulty
On Tue, Nov 3, 2009 at 12:57 PM, Jacob Kaplan-Moss wrote: > Yes, please. > > Special-casing built-in backends requires more code and leads to the > impression that external backends are somehow second-class citizens > This isn't -- or shouldn't be -- true. Sounds better to me as well; I'll make

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Waylan Limberg
On Tue, Nov 3, 2009 at 10:57 AM, Tobias McNulty wrote: > On Tue, Nov 3, 2009 at 8:31 AM, Yuri Baburov wrote: >> >> On Tue, Nov 3, 2009 at 9:27 AM, Tobias McNulty >> wrote: >> > I'm not a big fan of the red/green either.  They imply that Django code >> > is >> > "bad" and user code is "good". >>

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Tobias McNulty
On Tue, Nov 3, 2009 at 8:31 AM, Yuri Baburov wrote: > > On Tue, Nov 3, 2009 at 9:27 AM, Tobias McNulty > wrote: > > I'm not a big fan of the red/green either. They imply that Django code > is > > "bad" and user code is "good". > The opposite, in fact. > Django code is green, "good", user code is

Re: Calling update() on EmptyQuerySet updates all rows in database

2009-11-03 Thread Jacob Kaplan-Moss
On Tue, Nov 3, 2009 at 7:42 AM, Jens Ådne Rydland wrote: > This seems to be caused by EmptyQuerySet not overriding update(), > shouldn't this just return 0? Yup, that's a bug. Can you please open a ticket so that we don't forget this? Jacob --~--~-~--~~~---~--~~

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Yuri Baburov
Hi Tobias, On Tue, Nov 3, 2009 at 9:27 AM, Tobias McNulty wrote: > I'm not a big fan of the red/green either.  They imply that Django code is > "bad" and user code is "good". The opposite, in fact. Django code is green, "good", user code is red, "untrusted". -- Best regards, Yuri V. Baburov, I

Re: Session/cookie based messages (#4604)

2009-11-03 Thread Tobias McNulty
I've added some user docs to my bitbucket branch and would much appreciate any feedback from the group, as I'm much too steeped in it at this point to tell what's clear and what isn't: http://bitbucket.org/tobias.mcnulty/django-contrib-messages/src/tip/docs/ref/contrib/messages.txt If your commen

Calling update() on EmptyQuerySet updates all rows in database

2009-11-03 Thread Jens Ådne Rydland
Came across an issue with EmptyQuerySet today, it seems it does not behave correctly with regard to update(). (or that the documentation is lacking, I suspect it's the former) Assuming I have a model Foo of which I have say 42 stored instances in the database, each with a CharacterField "bar". I

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread tsmets
Any color blind in the group with advise on this ... ? \T, On Tue, 3 Nov 2009 02:35:35 -0800 (PST), SmileyChris wrote: > > Just chiming in that I'm also +1 to visual distinction, -1 to current > colors. > > On Nov 3, 4:27 pm, Tobias McNulty wrote: >> I'm not a big fan of the red/green eit

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread Russell Keith-Magee
On Tue, Nov 3, 2009 at 5:34 AM, Yuri Baburov wrote: > > Hi All, > > Since you are discussing and applying different features, > > I think it's time to ask what do you think of the subj. > > It's at http://code.djangoproject.com/ticket/11834 > > It adds some helpful color beauty to django 500 outp

Re: Enhanced debug output colors: django code is green, user code is red.

2009-11-03 Thread SmileyChris
Just chiming in that I'm also +1 to visual distinction, -1 to current colors. On Nov 3, 4:27 pm, Tobias McNulty wrote: > I'm not a big fan of the red/green either.  They imply that Django code is > "bad" and user code is "good".  What about something more subtle, like > different shades of gray