Re: CSRF proposal and patch ready for review

2009-09-21 Thread Luke Plant
OK, you convinced me. I really would rather this wasn't baked in, but given the migration issues and the fact that it is security related, I guess I can stomach it. I've updated the patch [1] to move things to builtin functionality. I also had to fix some bugs to get the csrf_protect decorat

Re: decorator_from_middleware change

2009-09-21 Thread Luke Plant
On Monday 21 September 2009 20:27:50 Jacob Kaplan-Moss wrote: > On Mon, Sep 21, 2009 at 1:21 PM, Luke Plant wrote: > > However, decorator_from_middleware is a pain, since it doesn't always > > return a an actual decorator, for "historical reasons". I need to change > > this to fix the bug. Is a

Re: Session/cookie based messages (#4604)

2009-09-21 Thread Tobias McNulty
On Sun, Sep 20, 2009 at 10:24 AM, Russell Keith-Magee < freakboy3...@gmail.com> wrote: > > You also mention that there are a number of other implementations, but > you haven't really given a compelling survey or analysis of the > alternatives - you've just blessed one in particular. Why? > I start

Re: Session/cookie based messages (#4604)

2009-09-21 Thread Tobias McNulty
On Sun, Sep 20, 2009 at 6:13 PM, Chris Beaven wrote: > Having some kind of defacto cross-request notification system makes > sense; it's a very common usage pattern. > Attaching these kind of messages to a User instance is wrong: there is > not an enforced one to one correlation between a user an

Re: decorator_from_middleware change

2009-09-21 Thread Jacob Kaplan-Moss
On Mon, Sep 21, 2009 at 1:21 PM, Luke Plant wrote: > However, decorator_from_middleware is a pain, since it doesn't always return a > an actual decorator, for "historical reasons".  I need to change this to fix > the bug.  Is anyone against this? No, I think this is precisely correct. I've been

decorator_from_middleware change

2009-09-21 Thread Luke Plant
Hi all, I need to fix #6371 [1], and I've found a nice way to do it (something like [2]). However, decorator_from_middleware is a pain, since it doesn't always return a an actual decorator, for "historical reasons". I need to change this to fix the bug. Is anyone against this? decorator_fr

Re: django.core.urlresolvers reverse, args and kwargs (Ticket 8764)

2009-09-21 Thread vegas
> However, be prepared for the outcome that your code may be rejected > and thrown away. In this case, the code is serving as a working > implementation of your proposal, and we still haven't been convinced > of your proposal. Just writing the code doesn't mean it will > automatically get accepted

What happened with #7048

2009-09-21 Thread Léon Dignòn
Since I really *love* the idea and already use the RemovableFileField snippet, I'd like to know what happened with #7048? Will we keep using the snippet, or are there plans to port them to django? The last comment is nearly one year old. -leond --~--~-~--~~~---~--~---

Re: Distorted layout of this group in Google Groups

2009-09-21 Thread Léon Dignòn
Not for me, but ?hl=en did the trick. Thanks On 21 Sep., 17:12, Dougal Matthews wrote: > 2009/9/21 Karen Tracey > > > > > > > On Mon, Sep 21, 2009 at 10:53 AM, Léon Dignòn wrote: > > >> Hello, > > >> Am I the only one with this problem? It's annoying because it covers > >> all the topics and al

Re: Distorted layout of this group in Google Groups

2009-09-21 Thread Dougal Matthews
2009/9/21 Karen Tracey > On Mon, Sep 21, 2009 at 10:53 AM, Léon Dignòn wrote: > >> >> Hello, >> >> Am I the only one with this problem? It's annoying because it covers >> all the topics and also text of discussions. >> >> > This appears to be some sort of google groups problem, that only affects

Re: Distorted layout of this group in Google Groups

2009-09-21 Thread Karen Tracey
On Mon, Sep 21, 2009 at 10:53 AM, Léon Dignòn wrote: > > Hello, > > today I browsed to the group django-developers in Google Groups. The > navigation bar with the adverts, which is normally on the right side, > covers all the discussion topics on the left. The layout is broken, > but only in this

Distorted layout of this group in Google Groups

2009-09-21 Thread Léon Dignòn
Hello, today I browsed to the group django-developers in Google Groups. The navigation bar with the adverts, which is normally on the right side, covers all the discussion topics on the left. The layout is broken, but only in this group. In django-users everything is fine. Am I the only one with

Re: CSRF proposal and patch ready for review

2009-09-21 Thread Russell Keith-Magee
On Sun, Sep 20, 2009 at 2:57 AM, Luke Plant wrote: > > On Saturday 19 September 2009 16:56:52 Russell Keith-Magee wrote: > >> On Fri, Sep 18, 2009 at 6:09 AM, Luke Plant wrote: >> >  If the target of a is internal: >> >   * add {% load csrf %} to the template and {% csrf_token %} to the form >>

Re: CSRF proposal and patch ready for review

2009-09-21 Thread Luke Plant
On Saturday 19 September 2009 16:56:52 Russell Keith-Magee wrote: > So - let's have both. A middleware enabled by default protects the > rest of the views. However, we can also have a view decorator lets us > protect admin (and other contrib apps) explicitly. If users disable > the middleware, ad

Re: SoC merge plans?

2009-09-21 Thread Russell Keith-Magee
On Mon, Sep 21, 2009 at 4:28 PM, Waldemar Kornewald wrote: > > On Sep 20, 1:54 pm, Russell Keith-Magee > wrote: >> Based on the discussion Alex and I had at the sprints, query_class() >> will still exist, but it will play a slightly different role - >> essentially, it will be more important for

Re: Looking for a project

2009-09-21 Thread Russell Keith-Magee
On Sun, Sep 20, 2009 at 11:29 PM, Daniel Watkins wrote: > > Hello all, > > As part of the third year of my computer science degree (at the > University of Warwick), I need to complete an individual project.  I'd > quite like to use this to do something for Django.  The project is meant > to be do

Re: Looking for a project

2009-09-21 Thread veena
Hello, I propose the "universal" Task Queue app similiar to one at Google App Engine http://code.google.com/appengine/docs/python/taskqueue/ Universal means to be able to run it on any hosted server where cron is available. Vaclav --~--~-~--~~~---~--~~ You rece

Re: SoC merge plans?

2009-09-21 Thread Waldemar Kornewald
On Sep 20, 1:54 pm, Russell Keith-Magee wrote: > Based on the discussion Alex and I had at the sprints, query_class() > will still exist, but it will play a slightly different role - > essentially, it will be more important for non-SQL backends than for > Oracle support. Could you please explain