Re: SoC merge plans?

2009-09-12 Thread Honza Král
Hi, see inline answers for info about model-validation On Sat, Sep 12, 2009 at 6:40 AM, Jacob Kaplan-Moss wrote: > > Hi folks -- > > I'd like to start thinking about merging the SoC branches. As far as I > can tell we've got solid, worth-merging work out of all six of 'em -- > WOOHOO! -- so let

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Jacob Kaplan-Moss
On Sat, Sep 12, 2009 at 6:19 PM, Ivan Sagalaev wrote: >> In the rare cases when I do need to split a URL into parts I just use >> urlsplit: >> >>      schema, domain, path, query, fragment = urlsplit(obj.url()) That's not in any way intitutive for a new user in the way that `obj.url().schema` is

Re: media -> admin_media Prefix Change

2009-09-12 Thread drozzy
Sorry about the attitude, sometimes I think a bit too much of myself. When do you think will get implemented? On Sep 11, 5:31 pm, Ivan Sagalaev wrote: > drozzy wrote: > > Yes, I Do, How about that he never replied to the Collin Grady's > > commend about HOW it would break the code. > > Seems lik

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Ivan Sagalaev
Ivan Sagalaev wrote: > In the rare cases when I do need to split a URL into parts I just use > urlsplit: > > schema, domain, path, query, fragment = urlsplit(obj.url()) Oh... And for template authors we could just make 5 filters returning those parts: {{ obj.url|domain }} --~--~---

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Ivan Sagalaev
Jacob Kaplan-Moss wrote: > * The fact that the returned URL is a string often means I end up > doing something like `obj.get_absolute_url().split('/')`. Objects are > better. I kind of disagree with the last sentence here. An object in place of a well-known native type (here, str) adds another a

Re: Question on ticket triage process

2009-09-12 Thread Eric Holscher
At first glance, tests and documentation. Everything needs both of these things before they go into trunk. Having a complete patch like that will make it a lot easier for someone to see what you're doing, and verify that you have fixed it. Cheers, Eric --~--~-~--~~~---

Re: SoC merge plans?

2009-09-12 Thread Alex Gaynor
Hey! On Sat, Sep 12, 2009 at 6:40 AM, Jacob Kaplan-Moss wrote: > > Hi folks -- > > I'd like to start thinking about merging the SoC branches. As far as I > can tell we've got solid, worth-merging work out of all six of 'em -- > WOOHOO! -- so let's cracking getting this stuff to trunk so people c

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread matehat
> One of the major advantages of URLObject is that it directly > subclasses unicode, so you can use it everywhere strings are used, but > it still has those handy methods and properties for manipulating/ > querying the URL. I agree that a unicode subclass for holding the url-related data is a rea

Question on ticket triage process

2009-09-12 Thread Ben Davis
I noticed that ticket #9015 has been sitting at "accepted" for almost a year now. What's the next step for such a ticket? Does it need a milestone? Also, who is responsible for setting milestones? --~--~-~--~~~---~--~~

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Zachary Voase
Looking back at my previous post it seems like I'm being aggressive or something. Sorry about that, that's 36 hours worth of sleep deprivation for you :) OK, so I think I've roughed together an idea of how you might use URLObject in url() methods (or get_url(), or __url__(), et cetera). You can s

SoC merge plans?

2009-09-12 Thread Jacob Kaplan-Moss
Hi folks -- I'd like to start thinking about merging the SoC branches. As far as I can tell we've got solid, worth-merging work out of all six of 'em -- WOOHOO! -- so let's cracking getting this stuff to trunk so people can play with it. I'd like to ask each mentor/student pair to give me a bit

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Jacob Kaplan-Moss
On Sat, Sep 12, 2009 at 8:42 AM, Thomas K. Adamcik wrote: > In essence we could add only one new method to the API that returns a > URL-object that provides access to the data: I like this idea a lot. It solves most of the problems I have with get_absolute_url: * I dislike the name -- far too v

Re: Moving the Django Project to a DVCS

2009-09-12 Thread Jacob Kaplan-Moss
On Fri, Sep 11, 2009 at 8:36 PM, Jared Kuolt wrote: > I propose that the core team set a timeline to resolve this, one way > or another, with input from the community. If we could agree on a common server format that let anyone use any DVCS they chose on their personal machines, then we'd get th

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Zachary Voase
I’d like to point you to http://code.zacharyvoase.com/urlobject/. You can include as much information in a URL as you like, and it's a subclass of unicode, so it can be used directly in templates, HTTP clients, et cetera. You can do stuff like URLObject(host='hostname', path='/foo/bar/'), or

Re: Replacing get_absolute_url, I am against it

2009-09-12 Thread Thomas K. Adamcik
On Thu, Sep 10, 2009 at 11:58:00AM -0400, Waylan Limberg wrote: > > Easy, get_url returns the entire url while get_url_path returns only > the "path" portion of a url. One could imagine feature creep resulting > in 'get_url_protocol', 'get_url_domain' etc. I wouldn't actually > recommend those be