Re: Skipping tests that are bound to fail?

2007-07-06 Thread Malcolm Tredinnick
On Fri, 2007-07-06 at 17:24 +0200, Michael Radziej wrote: > Hi, > > I think it's a bit confusing that even with correct settings some tests > always fail for some backends. If I happen to compile any other software > package and the test suite fails, I usually suspect something went wrong. In > a

Uncredited authors for Oracle backend work

2007-07-06 Thread Russell Keith-Magee
Hi all, It was pointed out to me this morning that when we merged the Oracle branch back into the trunk, the authors that contributed this work didn't make their way into the AUTHORS file. Such magnificent work should not go uncredited. As far as I can work out, the following people deserve cred

Re: Small concern in newforms-admin

2007-07-06 Thread James Bennett
On 7/6/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > I personally don't understand why we can't use email addresses as > usernames. You can, you just need to roll your own form. -- "Bureaucrat Conrad, you are technically correct -- the best kind of correct." --~--~-~--~~-

Re: Small concern in newforms-admin

2007-07-06 Thread [EMAIL PROTECTED]
I personally don't understand why we can't use email addresses as usernames. I know there are work arounds but it seems odd to me that we would have to do extra steps to allow a user to log in with their email. Just my $.02 -Chris On Jul 6, 10:59 am, "Jacob Kaplan-Moss" <[EMAIL PROTECTED]> wr

Re: Reverse URL lookups after the Unicode merge

2007-07-06 Thread Todd O'Bryan
Yep. I just saw it... On Fri, 2007-07-06 at 18:06 +0100, Matt Riggott wrote: > Yesterday evening I upgraded my site to the latest Subversion trunk so > I could take a look at all the Unicode loveliness. It seemed to work > with one minor problem. > > If I pass a method as the first argument to

Re: Skipping tests that are bound to fail?

2007-07-06 Thread Jacob Kaplan-Moss
On 7/6/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > http://code.djangoproject.com/ticket/4788 > > May I count your reply as "Approved"? Indeed; and thanks. Jacob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups

Re: empty list on "for" template tag

2007-07-06 Thread Jacob Kaplan-Moss
On 7/6/07, Rodolfo <[EMAIL PROTECTED]> wrote: > I'm new, so I don't know how to submit a patch. Please read: http://www.djangoproject.com/documentation/contributing/#submitting-patches In particular, please submit patches to the ticket tracker. Submitting patches to the list is a great way to g

empty list on "for" template tag

2007-07-06 Thread Rodolfo
I'm new, so I don't know how to submit a patch. This patch allow a tag "else" in a "for" loop. When the list is empty, it is called (as well "else" on a "if"). {% for i in items %} {{ i }} {% else %} no items {% endfor %} This is useful? The patch: Index: django/template/defaulttags.p

empty list on "for" template tag

2007-07-06 Thread Rodolfo
I'm new, so I don't know how to submit a patch. This patch allow a tag "else" in a "for" loop. When the list is empty, it is called (as well "else" on a "if"). {% for i in items %} {{ i }} {% else %} no items {% endfor %} This is useful? The patch: Index: django/template/defaulttags.p

Reverse URL lookups after the Unicode merge

2007-07-06 Thread Matt Riggott
Yesterday evening I upgraded my site to the latest Subversion trunk so I could take a look at all the Unicode loveliness. It seemed to work with one minor problem. If I pass a method as the first argument to django.core.urlresolvers.reverse, it always returns a NoReverseMatch error. However, if

Re: Skipping tests that are bound to fail?

2007-07-06 Thread Michael Radziej
On Fri, Jul 06, Jacob Kaplan-Moss wrote: > Yeah, that would be much better -- see the Python test suite, for > example; it gives a report at the end like "200 tests passed; 14 > skipped; 1 failure". http://code.djangoproject.com/ticket/4788 May I count your reply as "Approved"? Michael -- no

Re: Skipping tests that are bound to fail?

2007-07-06 Thread Jacob Kaplan-Moss
On 7/6/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > The serializer tests don't work for mysql/mysql_old with a transaction enabled > mysql storage engine since mysql doesn't test foreign key constraints at > commit > time but at row insertion time. There's nothing that could fix this ... Duh

Re: Skipping tests that are bound to fail?

2007-07-06 Thread Michael Radziej
On Fri, Jul 06, Jacob Kaplan-Moss wrote: > > On 7/6/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > > So--what do you think about skipping tests that *must* fail? > > AFAIK, there aren't any tests that are "supposed" to be failing; just > a few backend-dependent bugs that need to be tracked do

Re: Per request internal variables

2007-07-06 Thread PoBK
On Jul 6, 6:05 pm, PoBK <[EMAIL PROTECTED]> wrote: Ah crap... Wrong list. Sorry folks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develope

Per request internal variables

2007-07-06 Thread PoBK
I've got a case for passing an object between various components within my framework. The basic concept is similar to the way Mod_Python does things, where I can add an attribute to the request instance and that attribute will persist accross the current request only irrespective of which handler

Re: Skipping tests that are bound to fail?

2007-07-06 Thread Jacob Kaplan-Moss
On 7/6/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > So--what do you think about skipping tests that *must* fail? AFAIK, there aren't any tests that are "supposed" to be failing; just a few backend-dependent bugs that need to be tracked down. As a general principle, though, skipping tests tha

Re: Small concern in newforms-admin

2007-07-06 Thread Jacob Kaplan-Moss
On 7/6/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > I'm fine with removing that special-casing. We originally added it as > a usability feature before Django was open-sourced, because we found > our admin users were attempting to log in with their e-mail addresses, > but I can see how it might

Re: Small concern in newforms-admin

2007-07-06 Thread Adrian Holovaty
On 7/6/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > I've been merging the Unicode changes into newforms-admin tonight (won't > be finished until tomorrow; I'm losing willpower) and I came across this > code (in admin/sites.py): > [...] > I'm a little bit concerned by this. It means that if

Skipping tests that are bound to fail?

2007-07-06 Thread Michael Radziej
Hi, I think it's a bit confusing that even with correct settings some tests always fail for some backends. If I happen to compile any other software package and the test suite fails, I usually suspect something went wrong. In addition, failing tests make it hard to verify that everything is alrig

Small concern in newforms-admin

2007-07-06 Thread Malcolm Tredinnick
I've been merging the Unicode changes into newforms-admin tonight (won't be finished until tomorrow; I'm losing willpower) and I came across this code (in admin/sites.py): if u'@' in username: # Mistakenly entered e-mail address instead of username? Look it up. try:

Re: runtests failures

2007-07-06 Thread Malcolm Tredinnick
On Fri, 2007-07-06 at 08:59 -0500, Carl Karsten wrote: [...] > > All going smoothly there should be only only one failed test: > > modeltests.fixtures (two sub-tests in there fail because the default > > MySQL storage engine does not support transactions, but it's reported as > > "failures=1"). >

Re: runtests failures

2007-07-06 Thread Carl Karsten
>> >> Got an error creating the test database: (1007, "Can't create database >> 'django_t >> est_db'; database exists") >> >> It seems stuck there? perhaps I should mysql> drop database django_test_db; >> but that should never be done, right? :) > > It will be asking you if you want to drop the

Re: please help! need to know python version

2007-07-06 Thread Nicola Larosa
> James Bennett wrote: >> Django is compatible with any version of Python greater than 2.3 Don Arbow wrote: > You mean >=, right? :-) Well, 2.3.6 is strictly greater than 2.3 . ;-) http://www.python.org/download/releases/2.3.6/ -- Nicola Larosa - http://www.tekNico.net/ I accuse you, Mr. B

Re: please help! need to know python version

2007-07-06 Thread Nicola Larosa
Carl Karsten wrote: > Python code is not developed in Python. You should talk to the PyPy guys/gals someday. ;-) > that can be debated, but for the purposed of this thread, I think it > fits. Oh, you already took the above comment into account. :-) -- Nicola Larosa - http://www.tekNico.net/