Re: Ticket ping 3182

2007-04-23 Thread James Bennett
On 4/23/07, Joseph Perla <[EMAIL PROTECTED]> wrote: > I understand where you are coming from. However, I do not think I am > stepping out of bounds. The patch is self-contained, has proper > documentation, has been accepted, has been tested, is clearly labeled ready > for check in, has been revi

Re: Ticket ping 3182

2007-04-23 Thread Malcolm Tredinnick
On Tue, 2007-04-24 at 00:51 -0400, Joseph Perla wrote: > Hi Jacob, > > I understand where you are coming from. However, I do not think I am > stepping out of bounds. The patch is self-contained, has proper > documentation, has been accepted, has been tested, is clearly labeled > ready for check

Re: "easy pickings" in trac

2007-04-23 Thread Malcolm Tredinnick
On Tue, 2007-04-24 at 04:06 +, SmileyChris wrote: > Following on from an IRC discussion: > [15:52] SmileyChris: Maybe the ticket DB could use > another > level of granularity in triage: "Low hanging fruit" > [15:53] mattmcc: yea, i think it could > [15:53] S

Re: Ticket ping 3182

2007-04-23 Thread Joseph Perla
Hi Jacob, I understand where you are coming from. However, I do not think I am stepping out of bounds. The patch is self-contained, has proper documentation, has been accepted, has been tested, is clearly labeled ready for check in, has been reviewed and supported by a number of developers, and

Re: Templates: short comments {##} eats text

2007-04-23 Thread Malcolm Tredinnick
On Mon, 2007-04-23 at 17:46 +, tonnzor wrote: > I reviewed templates engine and found the problem. Here are the > patches: > > 1. template.Lexer incorrectly recognizes ALL tokens - it check only > the beginning of the token, ignoring the end of it. > [... code snipped ...] Please put any pa

"easy pickings" in trac

2007-04-23 Thread SmileyChris
Following on from an IRC discussion: [15:52]SmileyChris: Maybe the ticket DB could use another level of granularity in triage: "Low hanging fruit" [15:53]mattmcc: yea, i think it could [15:53]Since 'design decision needed' could be anything from a major concern to simply being

Re: The locmem patch and development progress

2007-04-23 Thread Malcolm Tredinnick
On Mon, 2007-04-23 at 13:28 -0700, Vinay Sajip wrote: > > > I think it's very easy to underestimate the amount of work required in > > > checking in a patch. It seems like a simple handful-of-lines patch like > > > yours > > > should be a no-brainer, but there's a whole bunch of steps I (or any >

Re: Oracle patch is ready

2007-04-23 Thread benk
Hi Matt, I can see where you are going regarding the manual "massaging" of "sqlall" output to create the database tables. My primary reason for the post was to ensure that I did not miss a piece of documentation showing how the tablespace could be set for other applications. To clear up potentia

Re: Resize images on demand

2007-04-23 Thread [EMAIL PROTECTED]
Fair enough. I think we've beaten this one to death and the current solution works fine for me (with the additional minor tweaks we've already mentioned). Thanks, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Grou

Re: Logging facility for Django

2007-04-23 Thread Vinay Sajip
Hi Fraser, > > (a) Setting NOTSET on the root logger will cause absolutely everything > > to go through the logging system - this could be unnecessary overhead as > > well as being too much information. > > My reason for doing this was indeed to capture as much information as > possible and then

Re: Logging facility for Django

2007-04-23 Thread Fraser Nevett
Hi Vinay, Thanks for taking the time to review and provide feedback on this. Your explanation of how the logging module works and how it can be used was really helpful. > (a) Setting NOTSET on the root logger will cause absolutely everything > to go through the logging system - this could be unn

Re: Ticket ping 3182

2007-04-23 Thread Michael Radziej
Hi Jacob, when I see requests like this, my usual reflex is to ask back whether they can apply the patch, test it and report back. What do you think of this? Michael --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups

Re: Ticket ping 3182

2007-04-23 Thread Jacob Kaplan-Moss
On 4/23/07, Joseph Perla <[EMAIL PROTECTED]> wrote: > Ping: simple, ready ticket #3182 is at 4 months and counting: > http://code.djangoproject.com/ticket/3182 . Thank you, Please don't do this. It's frustrating, annoying, and very impolite. Please remember that everyone who works on Django doe

Re: Resize images on demand

2007-04-23 Thread Chris Beaven
On 4/24/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > In other words, I want the width to always be 75 but the height can > vary based on the specifics of the image. Does this make sense? If > this is what I'd like to do, how would I do it with the tag as it > stands now? Well without spec

Ticket ping 3182

2007-04-23 Thread Joseph Perla
Ping: simple, ready ticket #3182 is at 4 months and counting: http://code.djangoproject.com/ticket/3182 . Thank you, j --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group,

Re: Logging facility for Django

2007-04-23 Thread Vinay Sajip
Hi Fraser, Thanks for sharing this app with us. After a quick read through, I've some points on the initialising code in middleware.py: #== handler = ThreadBufferedHandler() handler.setLevel(logging.NOTSET) handler.setFormatter(logging.Formatter()) logging.

Re: Resize images on demand

2007-04-23 Thread Michel Thadeu Sabchuk
Hi guys! I test your application and enjoy it SmileyChris, there is just a bug :), contrib/thumbnails/templatestags/__init__.py is missing, a "touch __init__.py" solves the problem ;) I like the way you return a Thumbnail object reather than just the string. Congratulations, very thanks to you!

Re: The locmem patch and development progress

2007-04-23 Thread Vinay Sajip
> > I think it's very easy to underestimate the amount of work required in > > checking in a patch. It seems like a simple handful-of-lines patch like > > yours > > should be a no-brainer, but there's a whole bunch of steps I (or any > > other bug fixer) has to go through before we can check a fi

Re: Oracle patch is ready

2007-04-23 Thread Carlo C8E Miron
Hello, 2007/4/23, Matt Boersma <[EMAIL PROTECTED]>: [...] > Having the db_tablespace parameter makes at least the models under > your control more self-documenting. But it's not perfect. Here are > the three options I can think of: > - Leave as-is, realizing it helps somewhat -0, it may lead t

Re: Patch #2070 in trunk

2007-04-23 Thread [EMAIL PROTECTED]
On 23 Apr, 21:23, "James Bennett" <[EMAIL PROTECTED]> wrote: > On 4/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Why isn't patch #2070 added to trunk yet? The current patch(es) won't > > work with trunk either. Is this "in the works"? > > From a quick glance at the discussion in the

Re: Patch #2070 in trunk

2007-04-23 Thread James Bennett
On 4/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Why isn't patch #2070 added to trunk yet? The current patch(es) won't > work with trunk either. Is this "in the works"? >From a quick glance at the discussion in the ticket, it appears that there hasn't been much activity on it since arou

Re: Patch #2070 in trunk

2007-04-23 Thread Jacob Kaplan-Moss
On 4/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Why isn't patch #2070 added to trunk yet? The current patch(es) won't > work with trunk either. You just answered your own question. Also, please read this: http://groups.google.com/group/django-developers/msg/f0149a288b776006 Jacob --

Patch #2070 in trunk

2007-04-23 Thread [EMAIL PROTECTED]
Why isn't patch #2070 added to trunk yet? The current patch(es) won't work with trunk either. Is this "in the works"? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group,

Re: Ticket #3297 (reopened) - FileField / ImageField - newforms

2007-04-23 Thread David Danier
> Anyone know the status on ticket #3297? It says "Ready for checkin", > but hasn't been touched in the last three weeks. Perhaps the status should be "Design decision needed" instead, as there are two different implementations in the ticket. (At least I think that's what keeps the patch from bei

Re: Templates: short comments {##} eats text

2007-04-23 Thread tonnzor
I reviewed templates engine and found the problem. Here are the patches: 1. template.Lexer incorrectly recognizes ALL tokens - it check only the beginning of the token, ignoring the end of it. Example: {{ my_var }} {{ other_var ## : variable other_var will be printed Current code (template/__i

Re: Resize images on demand

2007-04-23 Thread [EMAIL PROTECTED]
Ok, I think I'm understanding the distinction in your terminology. I definitely don't want an image that 75x10,000. Here's my scenario: Original Image 1 = 750 X 100, I would only like to specify that the new image was 75 wide and let it figure out that the new height should be 10 (preserve asp

Ticket #3297 (reopened) - FileField / ImageField - newforms

2007-04-23 Thread Silas
Anyone know the status on ticket #3297? It says "Ready for checkin", but hasn't been touched in the last three weeks. Reference: http://code.djangoproject.com/ticket/3297 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Gro

Re: Oracle patch is ready

2007-04-23 Thread Matt Boersma
That's a good point, Ben. There isn't any way to propagate the db_tablespace parameter back to models not directly under your control, like auth, sessions, etc., so the db_tablespace parameter we added is only a halfway solution. Our thinking was that for any "real" Oracle deployment, chances ar

Re: Logging facility for Django

2007-04-23 Thread Fraser Nevett
Thanks for the feedback. Jeremy, what database backend are you using? On MySQL I don't see any SQL getting logged. I guess registering the handler to the root logger must mean it gets all the log information from the other loggers too. It's on my to-do list to add the ability to filter by logger

Re: feature request, fields in models.STACKED

2007-04-23 Thread Florian Apolloner
On 23 Apr., 07:05, "James Bennett" <[EMAIL PROTECTED]> wrote: > Please keep in mind when suggesting features that one of the goals of > newforms-admin is to add flexibility for customizing the admin; > there's no way to directly support every possible feature everyone > will ask for, so customizat