Re: Re: Serious problems with the way Django handles file uploads

2006-09-14 Thread James Bennett
On 9/14/06, jp <[EMAIL PROTECTED]> wrote: > It is worth noting that parse_file_upload in django.http uses those > email and mail libraries a lot. For what I don't know. Yeah, I just realized that; I didn't poke deeply enough. I'm pretty certain that's because file uploads (typically) come in as "

Re: Serious problems with the way Django handles file uploads

2006-09-14 Thread Don Arbow
On Sep 14, 2006, at 9:41 PM, jp wrote: > > It is worth noting that parse_file_upload in django.http uses those > email and mail libraries a lot. For what I don't know. Django uses the email libraries to parse the uploaded content as HTTP uses MIME encoding for file uploads. Don --~--~

Re: Serious problems with the way Django handles file uploads

2006-09-14 Thread jp
It isn't using FileField, infact it isn't touching the DB or using any kind of manipulator at all. The form consists of a simple box which allows the user to upload a file. The file is then submitted in a POST request to the second view. The second view then calls to an outside library which con

Re: Serious problems with the way Django handles file uploads

2006-09-14 Thread James Bennett
On 9/13/06, jp <[EMAIL PROTECTED]> wrote: > http://paste.e-scribe.com/1564/ > http://paste.e-scribe.com/1565/ It's hard to infer exactly what's going on without knowing more about the actual code you're using; for example, that first set of profiler output is spending over 40% of its time in djan

Re: RequiredIfOtherFieldsGiven validator

2006-09-14 Thread Alan Green
Hi Andy, Yep, this little corner of the validator module is a bit messy. I ran into exactly the problems you describe. It turns out that Matt Rigott first reported problems in this area in June, along with a patch. I noticed in July, updated the patch, and added unit tests (very topical!) I've

Re: Proposal: Forms and BoundForms

2006-09-14 Thread Brantley Harris
On 9/13/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > On 9/14/06, Matthew Flanagan <[EMAIL PROTECTED]> wrote: > > > > On 14/09/06, Brantley Harris <[EMAIL PROTECTED]> wrote: > > > > For instance, using the given example: > > >message = TextField(label='Your message', > > > attributes=

Re: Proposal: Forms and BoundForms

2006-09-14 Thread Marc D.M.
On Tue, 2006-09-12 at 14:35 -0500, Adrian Holovaty wrote: > The template would look like this: > > > {% if form.sendername.errors > %}{{ form.sendername.errors.as_ul }}{% endif %} > Your name: {{ form.sendername.as_text }} > > {% if form.senderemail.errors %}{{ form.senderemail.

Re: Merquery patches

2006-09-14 Thread Rafael SDM Sierra
Hi again, I've finished my work for now, it's working fine. Please, someone look the patch3.diff and apply the differences into theirs respectives files http://code.djangoproject.com/ticket/2707 Thanks-- SDM UnderlinuxGarimpar.com--PEP-8"Mais vale um ponteiro na mao do que duas classes voando"CPF

Re: Patches, Tests and All the Rest

2006-09-14 Thread Michael Radziej
Hi Russell, Russell Keith-Magee wrote: > ... > Obviously, simple changes are no brainers. However, if a patch is a > deep change, I (as a developer) need to be convinced: > 1) That the problem actually exists > 2) That the proposed fix is the right approach to solve the problem > (e.g., there are