Re: the template system's whitespace handling

2006-08-12 Thread Gary Wilson
Tim Keating wrote: > I agree. It seems to me people either care about this or they don't. > Ergo the Django way to do this would be to make the whitespace handler > pluggable and set it globally in settings.py. If performance does not suffer, I'm with Malcolm that it should simply be done by defa

Re: modularity of apps

2006-08-12 Thread Gary Wilson
Malcolm Tredinnick wrote: > One point of view (mine!) is that if an application can't play nicely > with other applications and wants to do its own authentication, etc, > then it's not an application, it's a whole other project. The project > developer should have complete control over what the po

Re: django and LDAP support

2006-08-12 Thread Gary Wilson
Scott Paul Robertson wrote: > Let me know if there's anything else, > Scott You can remove the l.unbind_s() on line 77. It would also be great if the authenticate() method wasn't tied to the contrib.auth.models.User model. I, for one, use my own custom user model. Maybe extracting the parts th

Re: translation of content

2006-08-12 Thread Kenneth Gonsalves
On 13-Aug-06, at 12:51 AM, Ahmad Alhashemi wrote: > Then, in templates of a certain language site, you would look for > objects that are related to the current object in the translation > tables and link to them through their get_absolute_url preceded by > their site's address. > > Of course, as

Re: Re: Proposal: make templatetag loading magic a little more invisible

2006-08-12 Thread James Bennett
On 8/12/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > Yeah, I agree that we should improve the templatetag loading magic. > What about doing *both* -- improving the docs to note the ImportError > gotcha, *and* introspecting the ImportError? Sounds good, though if we introspect the ImportError

Re: Proposal: manipulator-aware validators in post-MR

2006-08-12 Thread Tom Tobin
On 8/11/06, Tom Tobin <[EMAIL PROTECTED]> wrote: > On 8/9/06, Tom Tobin <[EMAIL PROTECTED]> wrote: > > I'd like to restore this ability to Django trunk; there are a couple > > of ways I could go about this, and I'd like input as to which would be > > cleaner: > > I came up with a third possible wa

Re: Proposal: make templatetag loading magic a little more invisible

2006-08-12 Thread Adrian Holovaty
On 8/10/06, James Bennett <[EMAIL PROTECTED]> wrote: > 1) Document the way templatetag loading works, and advise tag authors > to wrap any imports they need in try/except and handle the situation > as appropriate (for example, by returning nothing from their tag, or > possibly raising ImproperlyCo

Re: Proposal: Can custom tag use namespace

2006-08-12 Thread limodou
On 8/13/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > On 8/7/06, limodou <[EMAIL PROTECTED]> wrote: > > How to use namespace? For example, > > > > {% load example %} > > {% example.testtag %} > > > > And I think if the namespace can be optional is better. I don't know > > if it's useful, but

Re: Incorrect error message in template.loader.filesystem.py

2006-08-12 Thread Adrian Holovaty
On 7/30/06, Martin <[EMAIL PROTECTED]> wrote: > if you pass `None` as `template_dirs` to the `load_template_source` > function, settings.TEMPLATE_DIRS will be used as default (this is done > in `get_template_sources`). > > If now, for whatever reason, no template file coud be found, a the > follow

Re: Re: A final post-0.91 release?

2006-08-12 Thread Adrian Holovaty
On 8/12/06, James Bennett <[EMAIL PROTECTED]> wrote: > > James, assuming you agree with these goals, are you volunteering to > > maintain the branch? :-) > > If that's what it takes, then yeah :) OK, I've set up a 0.91-bugfixes branch and given you commit access. Have at it! Adrian -- Adrian H

Re: Re: A final post-0.91 release?

2006-08-12 Thread James Bennett
On 8/11/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > As long as it's strictly bug fixes, and no feature additions, that > sounds fine by me. The reason I say "no feature additions" is that it > wouldn't be in our best interest to have another competing branch, as > we did with magic-removal vs

Re: Proposal: Can custom tag use namespace

2006-08-12 Thread Adrian Holovaty
On 8/7/06, limodou <[EMAIL PROTECTED]> wrote: > How to use namespace? For example, > > {% load example %} > {% example.testtag %} > > And I think if the namespace can be optional is better. I don't know > if it's useful, but sometimes I read others projects, and as I reading > the template, I don'

Re: django unicode-conversion, beginning

2006-08-12 Thread Adrian Holovaty
On 8/8/06, gabor <[EMAIL PROTECTED]> wrote: > i think unicodizing django can be done in 4 easily separated steps/parts: > > 1. request/response > 2. templating-system > 3. database-system > 4. "overall unicode-conversion". this is mostly about replacing > bytestrings with u"bla" in the code, and s

Re: A model_object.is_saved() method

2006-08-12 Thread Adrian Holovaty
On 8/12/06, Alan Green <[EMAIL PROTECTED]> wrote: > I would have used django.db.models.Model._get_pk_val() method, except > for the leading underscore marking the method as being for private > use. Hence the first option, at the top of this email. > > If exposing the primary key value like that wo

Re: multiple authentication and session keys

2006-08-12 Thread Scott Paul Robertson
On Thu, Aug 03, 2006 at 10:42:39PM -0700, Gary Wilson wrote: > > So, the mutli authentication seems to work well for the use case of a > site accepting more than one authentication source to access some area, > but not so well for the use case of a site accepting one source of > authentication in

big picture of middelware

2006-08-12 Thread dummy
Hi all, I read the middelware documentation on http://www.djangoproject.com/documentation/middleware/ and try to get a big picture of understanding. I also looked into the django/core/handler/base code. 1. incoming request is processed by each Middleware.process_request until a middleware re

Re: django and LDAP support

2006-08-12 Thread Scott Paul Robertson
On Sat, Aug 12, 2006 at 10:09:28AM +0200, [EMAIL PROTECTED] wrote: > for sure I understand now why you need a second search on update_user() and > with the defaults for mk_pre_auth_bind those two searches should be the same. > > A security question about get_ldap_user() > > def get_ldap_user

Re: translation of content

2006-08-12 Thread Ahmad Alhashemi
Kenneth Gonsalves wrote: > hi, > just a few random thoughts on translation of content. At first i was > leaning towards developing a dependant model for each model which > would hold translations. One thing i have realised is that of all the > field types, only three - CharField, TextField and num

Re: Proposed solution to deleting contents of FileField

2006-08-12 Thread Ian Clelland
On 8/9/06, James Bennett <[EMAIL PROTECTED]> wrote: > This is certainly a long-standing wart in Django, and on first glance > I like this solution a little better than the patch on #22, but we > also have a Summer of Code student working on major enhancements to > the admin's media support[1]; sin

A model_object.is_saved() method

2006-08-12 Thread Alan Green
Hi Everyone, I'd like to propose a small change to django.db.models.Model to make it neater to determine whether or not a model object is already stored in the database. Either: Option 1: Rename the _get_pk_val() method to get_pk_val(), marking it safe for public use. Option 2: Add a method name

Re: Pagination

2006-08-12 Thread Mike Cantelon
Malcolm Tredinnick wrote: > I'm not sure those functions make sense in the current ObjectPaginator > implementation. The thing is, that object doesn't even have a concept of > "current page". Instead it's an object from which you can retrieve any > individual page (random access) and get informati

Re: Pagination

2006-08-12 Thread Malcolm Tredinnick
On Sat, 2006-08-12 at 03:00 -0700, Mike Cantelon wrote: > I'm starting to play with Django and liking it... > > One thing I was wondering, though, about the pagination object is why > django/core/paginator.py doesn't have get_next_page and > get_previous_page functions (to return the appropriate

Pagination

2006-08-12 Thread Mike Cantelon
I'm starting to play with Django and liking it... One thing I was wondering, though, about the pagination object is why django/core/paginator.py doesn't have get_next_page and get_previous_page functions (to return the appropriate page numbers), although it does have has_next_page and has_previou

Re: django and LDAP support

2006-08-12 Thread dummy
Hi Scott, for sure I understand now why you need a second search on update_user() and with the defaults for mk_pre_auth_bind those two searches should be the same. A security question about get_ldap_user() def get_ldap_user(l, username): """ Helper method, makes a user obje