[TVM Discuss] [Questions] When to use reference vs pointer

2020-04-07 Thread shoubhik bhattacharya via TVM Discuss
Thanks for the explaination. --- [Visit Topic](https://discuss.tvm.ai/t/when-to-use-reference-vs-pointer/6261/3) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.ai/email/unsubscribe/6c92330aab7be

[TVM Discuss] [Questions] When to use reference vs pointer

2020-04-07 Thread tqchen via TVM Discuss
We should pass by the ObjectRef in most part of the codebase. The only exception for now is the Functor dispatching classes, where the first argument is the Object node class itself, and can be viewed as a Weak reference to the original node. There are some interest in moving the functor disp

[TVM Discuss] [Questions] When to use reference vs pointer

2020-04-07 Thread shoubhik bhattacharya via TVM Discuss
Hi, Here is an example ``` Expr Rewrite_(const CallNode* call_node, const Expr& post) final { const Call& ref_call = GetRef(call_node); ... ... const auto* post_node = post.as(); ``` This is a fairly standard convention in TVM C++ codebase. I am really confused about when we should p