[Apache TVM Discuss] [Questions] MergeComposite Error when defining custom pattern

2020-11-23 Thread Limenghao via Apache TVM Discuss
Thanks for your quick response and fix! --- [Visit Topic](https://discuss.tvm.apache.org/t/mergecomposite-error-when-defining-custom-pattern/8505/5) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.t

[Apache TVM Discuss] [Questions] MergeComposite Error when defining custom pattern

2020-11-23 Thread Cody H. Yu via Apache TVM Discuss
Make sense. PR filed: https://github.com/apache/incubator-tvm/pull/6958 --- [Visit Topic](https://discuss.tvm.apache.org/t/mergecomposite-error-when-defining-custom-pattern/8505/4) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails

[Apache TVM Discuss] [Questions] MergeComposite Error when defining custom pattern

2020-11-23 Thread Matthew Brookhart via Apache TVM Discuss
Ooh, good catch, sorry for this. I mostly left that check in as a debug tool for developing passes, but you're right, the partitioned graph won't match anymore if we're doing more specific things, like matching on names, or possibly matching on types. I think maybe we should just remove the ch

[Apache TVM Discuss] [Questions] MergeComposite Error when defining custom pattern

2020-11-23 Thread Cody H. Yu via Apache TVM Discuss
This is an interesting case and thanks for pointing out. I investigated it a bit and identified that this is not the problem of MergeComposite but the pattern partition. Specifically, you can reproduce this problem by replacing `assert test_pattern.match(r) # True` with `assert test_pattern.pa

[Apache TVM Discuss] [Questions] MergeComposite Error when defining custom pattern

2020-11-23 Thread Limenghao via Apache TVM Discuss
Hi, I want to define a custom pattern, and then use the MergeComposite function, but I met some problem. The pattern I defined is a sequence of nested ops including reshape,add,...My question is that why I got error when passing the is_var pattern to the callback of is_op, but it is fine wi