On Sun, Jun 28, 2009 at 12:39 PM, Martin Pitt wrote:
> I don't particularly like it either, TBH, but it seemed less evil to
> me than hardcoding /usr/sbin. If you prefer the latter, I'm fine with
> that, I just thought that we shouldn't break /usr/local.
I've hardcoded them, like I did with the ot
Hello Richard,
Richard Hughes [2009-06-28 9:13 +0100]:
> Urgh. Never code when sleep deprived. Sorry about that. Anyway, I've
> already been sent patches about the GError and the memory leak
Right, just saw them. Thanks for committing.
> the path thing still needs fixing. I'm not sure setting a
On Sat, Jun 27, 2009 at 6:28 PM, Martin Pitt wrote:
> sorry for sending this by mail, I'm currently in a train and offline.
np.
> I noticed that your recent pm-powersave patch works fine when dk-p is
> running in a foreground console, but it fails when being spawned
> through D-Bus, since it does
On Sat, Jun 27, 2009 at 9:18 PM, Roland Dreier wrote:
> command is allocated with g_strdup_printf() so it needs to be freed with
> g_free() when we're done with it.
Committed, thanks. Maybe I should code when less sleepy next time :-)
Richard.
___
devki
On Sat, Jun 27, 2009 at 9:18 PM, Roland Dreier wrote:
> If the local variable error in dkp_daemon_set_pmutils_powersave() isn't
> initialized, it's likely to hold some random non-NULL value from the
> stack and glib functions won't overwrite it to return on error. So if
> g_spawn_command_line_asyn
