Re: [Development] linuxfb

2012-07-10 Thread Girish Ramakrishnan
Hi Gunnar and Romain, Thanks :) I have cc'ed you guys on some other qpa patches and will send the rest of the linuxfb patches your way. Girish On Wed, Jul 11, 2012 at 12:01 AM, wrote: > I went through and +2 them. They all look sensible to me. As the other guys > are away atm, feel free to inc

Re: [Development] linuxfb

2012-07-10 Thread gunnar.sletta
I went through and +2 them. They all look sensible to me. As the other guys are away atm, feel free to include me in reviews in the future. cheers, Gunnar On Jul 10, 2012, at 1:58 PM, ext Girish Ramakrishnan wrote: > Hi, > I have a bunch of changes that make linuxfb compile, upto date with > la

Re: [Development] linuxfb

2012-07-10 Thread Romain Pokrzywka
Hi Girish, I don't have approver status, but feel free to include me in the reviews, I'll be glad to +1 and comment. the linuxfb plugin is something I'm interested in anyway and will eventually contribute to, so I don't mind reviewing the patches. Thanks! Romain -- Romain Pokrzywka | rom...@

[Development] linuxfb

2012-07-10 Thread Girish Ramakrishnan
Hi, I have a bunch of changes that make linuxfb compile, upto date with latest qpa code and display windows on the screen. You can see the changes at https://codereview.qt-project.org/#/t/32/. Looks like all the QPA folks are on vacation :) I have managed to get Samuel's +2 for a few changes and T