> From: Thiago Macieira
>To: development@qt-project.org
>Sent: Thursday, May 2, 2013 11:09 AM
>Subject: Re: [Development] kdelibs coding style
>On quinta-feira, 2 de maio de 2013 16.12.00, Daniel Teske wrote:
>> > I tried to compromise, but it seems like we
On quinta-feira, 2 de maio de 2013 16.12.00, Daniel Teske wrote:
> > I tried to compromise, but it seems like we don't want to compromise.
>
> Apparently you think there is some benefit, but so far you haven't actually
> explained what that benefit is. You should explain what those are before
> t
On Tuesday 30 Apr 2013 20:45:40 Thiago Macieira wrote:
> On terça-feira, 30 de abril de 2013 19.51.40, Daniel Teske wrote:
> > > So you suggest that KDE adopt the Qt style and Qt doesn't change
> > > anything?
> >
> > Why do they need to be the same?
>
> That was the request: can they be the same
On Wed, May 01, 2013 at 05:38:44AM +1000, Lorn Potter wrote:
>
> On 01/05/2013, at 2:47 AM, Oswald Buddenhagen
> wrote:
>
> > On Tue, Apr 30, 2013 at 09:01:51AM -0700, Thiago Macieira wrote:
> >> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
> >>> The rules are ok as they
On Tue, Apr 30, 2013 at 12:38 PM, Lorn Potter wrote:
>
> On 01/05/2013, at 2:47 AM, Oswald Buddenhagen
> wrote:
>
>> On Tue, Apr 30, 2013 at 09:01:51AM -0700, Thiago Macieira wrote:
>>> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
The rules are ok as they are (pretty
On 01/05/2013, at 2:47 AM, Oswald Buddenhagen
wrote:
> On Tue, Apr 30, 2013 at 09:01:51AM -0700, Thiago Macieira wrote:
>> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
>>> The rules are ok as they are (pretty much as _any_ set of consistently
>>> applied and not-completel
On 01/05/2013, at 2:01 AM, Thiago Macieira wrote:
> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
>> The rules are ok as they are (pretty much as _any_ set of consistently
>> applied and not-completely-weird rules). Opening them up only leads to
>> more review bikeshedding.
On terça-feira, 30 de abril de 2013 19.51.40, Daniel Teske wrote:
> > So you suggest that KDE adopt the Qt style and Qt doesn't change anything?
>
> Why do they need to be the same?
That was the request: can they be the same? They are identical except for the
braces-on-if.
I tried to compromise,
On Tuesday 30 Apr 2013 19:44:45 Thiago Macieira wrote:
> On terça-feira, 30 de abril de 2013 18.47.33, Oswald Buddenhagen wrote:
> > on a personal note, while i strongly sympathize with the diff
> > minimization philosophy, i also feel quite a dislike for excess braces.
> > adding to that the in th
On terça-feira, 30 de abril de 2013 18.47.33, Oswald Buddenhagen wrote:
> on a personal note, while i strongly sympathize with the diff
> minimization philosophy, i also feel quite a dislike for excess braces.
> adding to that the in this case pretty persuasive consideration of the
> status quo, i'
On Tue, Apr 30, 2013 at 09:01:51AM -0700, Thiago Macieira wrote:
> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
> > The rules are ok as they are (pretty much as _any_ set of consistently
> > applied and not-completely-weird rules). Opening them up only leads to
> > more revie
On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
> The rules are ok as they are (pretty much as _any_ set of consistently
> applied and not-completely-weird rules). Opening them up only leads to
> more review bikeshedding.
>
> It's not that people actively change coding style in
On Tue, Apr 30, 2013 at 07:37:36AM -0600, Charley Bay wrote:
> Samuel sayeth:
>
> > A good reason for using the
> >
> > Foo()
> > : x(0)
> > , y(0)
> > {
> > }
> >
> > syntax for initializer lists after all is to make diffs easier to read
> > when adding or removing a member variable. Th
On Tue, Apr 30, 2013 at 5:13 PM, Thiago Macieira
wrote:
> On terça-feira, 30 de abril de 2013 08.54.31, Samuel Rødal wrote:
>> A good reason for using the
>>
>> Foo()
>> : x(0)
>> , y(0)
>
> This is extremely ugly and should be discouraged.
If it is about the sum of all opinions, I agre
On terça-feira, 30 de abril de 2013 08.54.31, Samuel Rødal wrote:
> A good reason for using the
>
> Foo()
> : x(0)
> , y(0)
This is extremely ugly and should be discouraged.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
On 04/29/2013 10:31 PM, Olivier Goffart wrote:
>
> I support the change to optionally permit the braces.
>
+1. Have always disliked this particular style.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinf
Samuel sayeth:
> A good reason for using the
>
> Foo()
> : x(0)
> , y(0)
> {
> }
>
> syntax for initializer lists after all is to make diffs easier to read
> when adding or removing a member variable. The same argument could be
> made for permitting braces for one-line if-statements.
>
On 04/29/2013 10:31 PM, Olivier Goffart wrote:
> On Monday 29 April 2013 09:43:55 Thiago Macieira wrote:
>> On segunda-feira, 29 de abril de 2013 17.16.49, Sergio Martins wrote:
>>> The thing is, I just discovered that the kdelibs style[1] has a little
>>> difference from Qt, it uses braces for one
On Mon, Apr 29, 2013 at 10:37:10PM +0200, Giuseppe D'Angelo wrote:
> On 29 April 2013 21:20, Thiago Macieira wrote:
> > On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote:
> >> On 29 April 2013 18:43, Thiago Macieira wrote:
> >> > With that in mind, I would suggest we change
On 29 April 2013 21:20, Thiago Macieira wrote:
> On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote:
>> On 29 April 2013 18:43, Thiago Macieira wrote:
>> > With that in mind, I would suggest we change *both* coding styles to
>> > optionally permit the braces, and strongly sug
On Monday 29 April 2013 09:43:55 Thiago Macieira wrote:
> On segunda-feira, 29 de abril de 2013 17.16.49, Sergio Martins wrote:
> > The thing is, I just discovered that the kdelibs style[1] has a little
> > difference from Qt, it uses braces for one-line if statements.
> >
> > This seems to be a d
On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote:
> On 29 April 2013 18:43, Thiago Macieira wrote:
> > With that in mind, I would suggest we change *both* coding styles to
> > optionally permit the braces, and strongly suggest it for more-complex
> > conditionals.
>
> In Qt
On 29 April 2013 18:43, Thiago Macieira wrote:
>
> With that in mind, I would suggest we change *both* coding styles to
> optionally permit the braces, and strongly suggest it for more-complex
> conditionals.
In Qt the braces are already mandatory if the condition spans over
more than one line (w
On segunda-feira, 29 de abril de 2013 17.16.49, Sergio Martins wrote:
> The thing is, I just discovered that the kdelibs style[1] has a little
> difference from Qt, it uses braces for one-line if statements.
>
> This seems to be a documentation/policy only rule, as the kdelibs code is
> full of if
24 matches
Mail list logo
