Re: [Development] epoll event dispatcher

2013-08-13 Thread Thiago Macieira
On terça-feira, 13 de agosto de 2013 19:09:36, Florian Weimer wrote: > >> that doesn't explain why we didn't bulk-fix it. > > > > Oh, sorry. I just meant to give Florian a direct link to the actual rules. > > He said he was copying from related code, so he hadn't probably yet found > > the rules.

Re: [Development] epoll event dispatcher

2013-08-13 Thread Thiago Macieira
On terça-feira, 13 de agosto de 2013 18:11:50, Oswald Buddenhagen wrote: > > Better yet: http://qt-project.org/wiki/Qt_Coding_Style > > that doesn't explain why we didn't bulk-fix it. Oh, sorry. I just meant to give Florian a direct link to the actual rules. He said he was copying from related c

Re: [Development] epoll event dispatcher

2013-08-13 Thread Thiago Macieira
On terça-feira, 13 de agosto de 2013 13:54:36, Oswald Buddenhagen wrote: > > Hmm. I think the patch more or less follows the existing practice in > > the changed files. It appears they haven't been cleaned up to match the > > coding standard. > > yes, there is quite some "legacy" coding style

Re: [Development] epoll event dispatcher

2013-08-09 Thread Thiago Macieira
On sexta-feira, 9 de agosto de 2013 19:04:56, Oswald Buddenhagen wrote: > i'll note that the qml guys identified that as a major bottleneck a few > years ago and wrote their own timer code. Probably for the same reason why we identified the glib GTimeout as a major bottleneck (and grew worse for

Re: [Development] epoll event dispatcher

2013-08-09 Thread Thiago Macieira
On sexta-feira, 9 de agosto de 2013 08:48:12, Thiago Macieira wrote: > If anything, we'd need to change our interface in QSocketNotifier to > benefit from the edge trigger. We toggle our write notifications all the > time because we need the edge, not the level. > > No, epoll makes no sense until

Re: [Development] epoll event dispatcher

2013-08-09 Thread Thiago Macieira
On sexta-feira, 9 de agosto de 2013 14:09:12, Cyril Oblikov wrote: > OK, thanks for clarifying. Can it be somehow optimized? Yes, but it will mostly require a major rewrite of all classes derived from it. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Sour

Re: [Development] epoll event dispatcher

2013-08-09 Thread Thiago Macieira
On sexta-feira, 9 de agosto de 2013 10:39:33, Oswald Buddenhagen wrote: > On Thu, Aug 08, 2013 at 09:13:42AM -0700, Thiago Macieira wrote: > > Yes, that would be ideal. That would require iterating over all socket > > notifiers we have on this event dispatcher, to determine which ones > > have chan

Re: [Development] epoll event dispatcher

2013-08-09 Thread Thiago Macieira
On quinta-feira, 8 de agosto de 2013 08:18:18, Thiago Macieira wrote: > Despite the comments in it, the task is actually unrelated. It's asking > about a poll-based dispatcher, not an epoll-based one. A poll-based > dispatcher makes a lot of sense and I'd love to see it implemented. A patch for p

Re: [Development] epoll event dispatcher

2013-08-09 Thread Cyril Oblikov
OK, thanks for clarifying. Can it be somehow optimized? On Fri, Aug 09, 2013 at 12:38:31PM +0300, Cyril Oblikov wrote: > > another consideration is that it is utterly unlikely that the event > > loop's ability to efficiently process hundreds of sockets is of any > > relevance to qt. > > Sure this i

Re: [Development] epoll event dispatcher

2013-08-08 Thread Thiago Macieira
On quinta-feira, 8 de agosto de 2013 17:46:05, Oswald Buddenhagen wrote: > epoll() perfectly fits the design of an object-oriented notifier > interface as we have. why does qt code toggle the notifiers so often? > would it be possible to rewrite it? Not sure. There is some code that does it becaus

Re: [Development] epoll event dispatcher

2013-08-08 Thread Thiago Macieira
On quinta-feira, 8 de agosto de 2013 10:38:10, Cyril Oblikov wrote: > Hi guys, > > I wonder if anyone is working on epoll event dispatcher for Qt5 to > replace current select/poll based solution? > > For now I've only found QTBUG-24957 [1], and two different > implementations on github based on l