Re: [Development] Using Git notes to reflect actual cherry-picks

2022-07-26 Thread Thiago Macieira
On Wednesday, 25 May 2022 02:48:52 PDT Daniel Smith wrote: > This shouldn’t be too difficult to set up as a cron job on the gerrit server > to run in all repos—I do agree with Tor Arne though that the notes should > be namespaced if possible. > > Could you reupload the change to qt/qtqa/scripts/ge

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-05-25 Thread Daniel Smith
Of Tor Arne Vestbø Sent: Wednesday, May 25, 2022 11:07 AM To: Macieira, Thiago Cc: development@qt-project.org Subject: Re: [Development] Using Git notes to reflect actual cherry-picks See comment in review. I think a prerequisite for running this kind of script against our repos is that the

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-05-25 Thread Tor Arne Vestbø
See comment in review. I think a prerequisite for running this kind of script against our repos is that the notes are namespaced, e.g. refs/notes/cherry-picks so that fetching and showing them in git log output is optional. Other than that I think it’s a nice feature :) Tor Arne On 25 May 202

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-05-24 Thread Thiago Macieira
On Saturday, 5 March 2022 11:07:17 PDT Thiago Macieira wrote: > > All this requires is that someone run a cron job every week and have > > rights > > to push to the refs/notes/* hierarchy. > > Anyone? No one? The script here is working. https://codereview.qt-project.org/c/qt/qtbase/+/395465 --

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-03-05 Thread Thiago Macieira
On Monday, 21 February 2022 17:21:30 PST Thiago Macieira wrote: > On Saturday, 12 February 2022 07:15:36 PST Tor Arne Vestbø wrote: > > Very cool! As ossi suggests, this could potentially be handled by Gerrit, > > similar to this: > > > > https://gerrit.googlesource.com/plugins/reviewnotes/%2B/mas

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-02-21 Thread Thiago Macieira
On Saturday, 12 February 2022 07:15:36 PST Tor Arne Vestbø wrote: > Very cool! As ossi suggests, this could potentially be handled by Gerrit, > similar to this: > > https://gerrit.googlesource.com/plugins/reviewnotes/%2B/master/src/main/reso > urces/Documentation/refs-notes-review.md

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-02-12 Thread Tor Arne Vestbø
Very cool! As ossi suggests, this could potentially be handled by Gerrit, similar to this: https://gerrit.googlesource.com/plugins/reviewnotes/%2B/master/src/main/resources/Documentation/refs-notes-review.md

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-02-12 Thread Oswald Buddenhagen
On Fri, Feb 11, 2022 at 11:04:25PM -0800, Thiago Macieira wrote: (I don't think qtbase is the right place for this) yeah, probably somewhere in qtqa/. I'd like to propose we use Git notes to include information into commits about successful cherry-picks. yay, i've been arguing for that befo

[Development] Using Git notes to reflect actual cherry-picks

2022-02-11 Thread Thiago Macieira
Implementation: https://codereview.qt-project.org/c/qt/qtbase/+/395465 (I don't think qtbase is the right place for this) TL;DR: I'd like to propose we use Git notes to include information into commits about successful cherry-picks. I have the scripts done, see above. All we need is that they