Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-03 Thread Thiago Macieira
On Tuesday, 3 July 2018 01:05:47 PDT Lars Knoll wrote: > Are you sure you already have the fix (it went into 5.11 first)? Because > with the patch, you shouldn't see those 'line #xxx' things at all anymore. > bidiTest should just report one single line. *facepalm* Right, this was in dev... -- T

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-03 Thread Liang Qi
On Tue, 3 Jul 2018 at 10:05, Lars Knoll wrote: > > On 3 Jul 2018, at 05:55, Thiago Macieira > wrote: > > > > On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: > >> Hi Thiago, > >> > >> maybe https://codereview.qt-project.org/#/c/233693/ helps with this > case. > > > > It did help some. I

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-03 Thread Lars Knoll
> On 3 Jul 2018, at 05:55, Thiago Macieira wrote: > > On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: >> Hi Thiago, >> >> maybe https://codereview.qt-project.org/#/c/233693/ helps with this case. > > It did help some. It went from > > PASS : tst_QComplexText::bidiTest(line #201771

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-02 Thread Thiago Macieira
On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: > Hi Thiago, > > maybe https://codereview.qt-project.org/#/c/233693/ helps with this case. It did help some. It went from PASS : tst_QComplexText::bidiTest(line #201771 (LTR) to PASS : tst_QComplexText::bidiTest(line #456371 (RTL))

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-02 Thread Edward Welbourne
On 30 Jun 2018, at 18:14, Thiago Macieira wrote: >> I tried to add a change to increase the timeout >> https://codereview.qt-project.org/233691 >> but Liang pointed out that my inspiration is a change by Rohan McGovern back >> in 2012: >> >> dd3e4f1dbe8 tests/auto/network/access/qnetworkreply/test/

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-06-30 Thread Lars Knoll
Hi Thiago, maybe https://codereview.qt-project.org/#/c/233693/ helps with this case. Cheers, Lars On 30 Jun 2018, at 18:14, Thiago Macieira mailto:thiago.macie...@intel.com>> wrote: It has failed now four times in the last 24 hours and is responsible for all failures that didn't fail with a ne

[Development] Urgent: increase timeout for tst_qcomplextext

2018-06-30 Thread Thiago Macieira
It has failed now four times in the last 24 hours and is responsible for all failures that didn't fail with a network issue first. I ran it on my machine and it took about a minute, while I was also compiling something else. Given the usual 30:1 slowness of the CI, it could take as much as half