Re: [Development] Two QStorageInfo classes

2014-10-04 Thread Sze Howe Koh
On 5 October 2014 07:00, Aleix Pol wrote: > On Fri, Oct 3, 2014 at 7:33 PM, Thiago Macieira > wrote: >> >> On Friday 03 October 2014 18:11:22 Aleix Pol wrote: >> > If I do "git submodule update" from a qt5 in 5.4 branch, the HEAD commit >> > in >> > qtsystems is 4a324f7. If I "git checkout origin

Re: [Development] Two QStorageInfo classes

2014-10-04 Thread Aleix Pol
On Fri, Oct 3, 2014 at 7:33 PM, Thiago Macieira wrote: > On Friday 03 October 2014 18:11:22 Aleix Pol wrote: > > If I do "git submodule update" from a qt5 in 5.4 branch, the HEAD commit > in > > qtsystems is 4a324f7. If I "git checkout origin 5.4" the HEAD commit > > is 3b3b759c6. > > > > Isn't t

Re: [Development] Two QStorageInfo classes

2014-10-03 Thread Matthias WALTER
..@qt-project.org] De la part de Lorn Potter Envoyé : vendredi 3 octobre 2014 20:19 À : Aleix Pol Cc : development Objet : Re: [Development] Two QStorageInfo classes This change removes the QtSystemInfo QStorage https://codereview.qt-project.org/#/c/95730/ On 3 Oct 2014, at 8:46 pm, Aleix Pol wrote:

Re: [Development] Two QStorageInfo classes

2014-10-03 Thread Lorn Potter
This change removes the QtSystemInfo QStorage https://codereview.qt-project.org/#/c/95730/ On 3 Oct 2014, at 8:46 pm, Aleix Pol wrote: > Hi, > I just pulled Qt and then it wouldn't build. After investigating a bit, I > found this: > ~/qt5 (5.4)$ find . -name qstorageinfo.h > ./qtsystems/src/sy

Re: [Development] Two QStorageInfo classes

2014-10-03 Thread Thiago Macieira
On Friday 03 October 2014 18:11:22 Aleix Pol wrote: > If I do "git submodule update" from a qt5 in 5.4 branch, the HEAD commit in > qtsystems is 4a324f7. If I "git checkout origin 5.4" the HEAD commit > is 3b3b759c6. > > Isn't the reason why submodules points to an old snapshot that the provided >

Re: [Development] Two QStorageInfo classes

2014-10-03 Thread Aleix Pol
On Fri, Oct 3, 2014 at 4:47 PM, Thiago Macieira wrote: > On Friday 03 October 2014 12:46:03 Aleix Pol wrote: > > Hi, > > I just pulled Qt and then it wouldn't build. After investigating a bit, I > > found this: > > ~/qt5 (5.4)$ find . -name qstorageinfo.h > > ./qtsystems/src/systeminfo/qstoragein

Re: [Development] Two QStorageInfo classes

2014-10-03 Thread Thiago Macieira
On Friday 03 October 2014 12:46:03 Aleix Pol wrote: > Hi, > I just pulled Qt and then it wouldn't build. After investigating a bit, I > found this: > ~/qt5 (5.4)$ find . -name qstorageinfo.h > ./qtsystems/src/systeminfo/qstorageinfo.h > ./qtbase/src/corelib/io/qstorageinfo.h > > Now doing a "git c

[Development] Two QStorageInfo classes

2014-10-03 Thread Aleix Pol
Hi, I just pulled Qt and then it wouldn't build. After investigating a bit, I found this: ~/qt5 (5.4)$ find . -name qstorageinfo.h ./qtsystems/src/systeminfo/qstorageinfo.h ./qtbase/src/corelib/io/qstorageinfo.h Now doing a "git checkout origin dev" fixed the issue, but then how did that happen? I