Re: [Development] Trouble getting reviews in months and years

2024-10-13 Thread Ilya Fedin
On Mon, 14 Oct 2024 09:15:45 +1000 Lorn Potter wrote: > Other open source projects are the > same. You might have to ping people on the mailing list, 2, 3 times, > or one of the several developer chat places like discord and irc. > Developers are often busy with their own things. Yeah but such

Re: [Development] Trouble getting reviews in months and years

2024-10-13 Thread Lorn Potter
Hi- On 8/10/24 09:41, Ilya Fedin wrote: Well, I told my experience. I was also asking another person who is trying to contribute Qt, too, about his expereince, he said he also can't get reviews in reasonable times. IIRC he has has too around 10 open changes and most of them are open for a long t

Re: [Development] Trouble getting reviews in months and years

2024-10-11 Thread Ilya Fedin
On Fri, 11 Oct 2024 15:46:20 + Volker Hilsheimer wrote: > Hi Ilya, > > > I’m sorry that your experience with contributing to Qt is less than > stellar. Working on the platform integration of Qt, and perhaps in > particular on the Xcb integration, is certainly challenging, for at > least two

Re: [Development] Trouble getting reviews in months and years

2024-10-11 Thread Volker Hilsheimer via Development
> On 8 Oct 2024, at 01:41, Ilya Fedin wrote: > > On Mon, 07 Oct 2024 07:42:11 -0700 > Thiago Macieira wrote: > >> You're generalising. The fact that those contributions weren't wanted >> or were misunderstood is not an indication that everyone's >> contributions will suffer the same consequen

Re: [Development] Trouble getting reviews in months and years

2024-10-07 Thread Ilya Fedin
On Mon, 07 Oct 2024 07:42:11 -0700 Thiago Macieira wrote: > You're generalising. The fact that those contributions weren't wanted > or were misunderstood is not an indication that everyone's > contributions will suffer the same consequences. > Well, I told my experience. I was also asking anoth

Re: [Development] Trouble getting reviews in months and years

2024-10-07 Thread Thiago Macieira
On Sunday 6 October 2024 13:41:09 GMT-7 Ilya Fedin wrote: > There was a thread on the mailing list on how to get new contributors. > It was discussing problems like simplifying cloning the repo. I'd say > the problem is not that but just that Qt doesn't really need or want > contributions. It seems

Re: [Development] Trouble getting reviews in months and years

2024-10-07 Thread Tor Arne Vestbø via Development
Hi Ilya, You’re completely right that simplifying the process of contributing to Qt goes beyond technical roadblocks such as cloning repositories, building, and Gerrit setup. Once those issues are solved, it comes down to making a convincing and thorough case for why a change is both correct, a

Re: [Development] Trouble getting reviews in months and years

2024-10-06 Thread Ilya Fedin
If anyone has any interest on how https://lists.qt-project.org/pipermail/development/2024-April/045167.html did end, here's the summary: > https://codereview.qt-project.org/c/qt/qtbase/+/343628 Maybe there was any misundestanding during the review but it has felt like reviewers are gaslighting me

Re: [Development] Trouble getting reviews in months and years

2024-05-08 Thread Ilya Fedin
Hello Morten, On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: > These are of the “need to get around to it” category for my part. > For 528953 we need to make sure we are not regressing > other platforms, and I have at least one related bug I’d like to take > a look at at the same time.

Re: [Development] Trouble getting reviews in months and years

2024-04-16 Thread Ilya Fedin
On Tue, 16 Apr 2024 08:12:51 + Morten Sørvig wrote: > Should this be up to the application (somehow)? There is more than > one way to handle DPI settings on X11, so we could enable apps to > make choices which are different from the Qt default. Well, there's only one way currently implemente

Re: [Development] Trouble getting reviews in months and years

2024-04-16 Thread Morten Sørvig via Development
On Apr 12, 2024, at 11:51, Ilya Fedin wrote: On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: - Should Qt read Gdk settings? Should the XCB platform plugin read Gdk settings? The current approach is that we stick to X11-level settings, at least as far as DPI is concerned. I hope the a

Re: [Development] Trouble getting reviews in months and years

2024-04-12 Thread Ilya Fedin
On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: > Hello Ilya! > > > On Apr 9, 2024, at 00:17, Ilya Fedin wrote: > > > > > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > > > This one could be candidate for discussion on the

Re: [Development] Trouble getting reviews in months and years

2024-04-11 Thread Morten Sørvig via Development
Hello Ilya! > On Apr 9, 2024, at 00:17, Ilya Fedin wrote: > > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is 1.5 > years old and no review > This one could be candidate for discussion on the mailing list. There are two issues: - Should Qt read Gdk settings? Should the

Re: [Development] Trouble getting reviews in months and years

2024-04-09 Thread Thiago Macieira
On Tuesday 9 April 2024 10:12:48 PDT Ilya Fedin wrote: > Oh, sorry, I was answering in quite a sleepy state but now I checked the > change you quoted and it seems I did almost everything as you said? The > change is supplied at Nov 23, 2022 which is long before Christmas, with > only a rebase and a

Re: [Development] Trouble getting reviews in months and years

2024-04-09 Thread Ilya Fedin
On Mon, 08 Apr 2024 22:36:56 -0500 Thiago Macieira wrote: > On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > Submitted during Christmas break and no changes since New Years. No > won

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Ilya Fedin
В Mon, 08 Apr 2024 22:36:56 -0500 Thiago Macieira пишет: > On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > Submitted during Christmas break and no changes since New Years. No > wond

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Thiago Macieira
On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is 1.5 > years old and no review Submitted during Christmas break and no changes since New Years. No wonder it was missed. You should have sent a "ping" during the second week o

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Chris Adams
Hi, I have no horse in these particular races, but I am going to throw my 2c in regardless: In my opinion, 6 months or so delay on some reviews is fairly acceptable (there can be higher-priority items which take attention, it's understandable). But beyond that, especially if the contributor is ac

[Development] Trouble getting reviews in months and years

2024-04-08 Thread Ilya Fedin
I have multiple changes which hang for months and years which no idea what to do to push them forward... I tried to write there asking for review but reviewers seem to just ignore the messages... 1. The oldest change I have is https://codereview.qt-project.org/c/qt/qtbase/+/343628 which is 3 years