Re: [Development] Support for custom Diffie-Hellman parameters in QSslSocket

2015-05-26 Thread Mikkel Krautz
For anyone following this, the change is now at: https://codereview.qt-project.org/#/c/113070 On Tue, May 26, 2015 at 12:11 PM, Mikkel Krautz wrote: > Hi Rich, > > Sorry for the clash of work -- I had this sketch done on Saturday, and > thought I would have more time during the weekend to hack o

Re: [Development] Support for custom Diffie-Hellman parameters in QSslSocket

2015-05-26 Thread Mikkel Krautz
Hi Rich, Sorry for the clash of work -- I had this sketch done on Saturday, and thought I would have more time during the weekend to hack on it. However that turned out not to be the case, so I threw this out here. I'll strive to be more communicative in the future. :-) WRT tests and docs: I'm aw

Re: [Development] Support for custom Diffie-Hellman parameters in QSslSocket

2015-05-26 Thread Richard Moore
Hi Mikkel, Please could you upload your change to gerrit so I can review it properly? I was actually implementing this yesterday, but since you've got it done I'll abandon my change. If you add me as the reviewer then I'll add the other relevant people. The change seems mainly okay, but there are

[Development] Support for custom Diffie-Hellman parameters in QSslSocket

2015-05-25 Thread Mikkel Krautz
Hi, I've been working on adding the ability to set custom DH parameters for QSslSocket and I want to start discussing an API for the feature, rather than jumping directly to a code review. I have a preliminary patch that adds a sketch of the API I'm envisioning: https://gist.github.com/mkrautz/69