Re: [Development] Source break policy for function overloads

2017-01-13 Thread Marc Mutz
On 2016-07-13 23:55, Lars Knoll wrote: On 13 Jul 2016, at 20:10, Marc Mutz wrote: [...] It should also be noted that there are two categories of SiCs: a. those that can be fixed client-side without breaking compat with older Qt versions, and b. those which cannot IMO, SiCs of type (a) ar

Re: [Development] Source break policy for function overloads

2016-07-18 Thread Louai Al-Khanji
> On Jul 13, 2016, at 9:47 AM, Thiago Macieira > wrote: > > Em quarta-feira, 13 de julho de 2016, às 10:44:13 PDT, Alexander Blasche > escreveu: >> Hi, >> >> Yesterday, I stumbled over a break in QtSerialBus due to the addition of new >> QTimer::setInterval(..) overloads in qtbase/dev. This w

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Thiago Macieira
Em quarta-feira, 13 de julho de 2016, às 23:29:42 PDT, Richard Moore escreveu: > On 13 July 2016 at 19:10, Marc Mutz wrote: > > Renaming a public inline function of a non-exported class is BC, but SiC > > Type > > (b), so not acceptable. > > ​Good analysis, however isn't the compiler allowed to n

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Richard Moore
On 13 July 2016 at 19:10, Marc Mutz wrote: > Renaming a public inline function of a non-exported class is BC, but SiC > Type > (b), so not acceptable. > ​Good analysis, however isn't the compiler allowed to not inline stuff too which would mean this example is not b/c either. ​ ​Cheers Rich.​

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Marc Mutz
On Wednesday 13 July 2016 18:47:28 Thiago Macieira wrote: > We do have this policy since 5.0 that we have to be careful about > overloads due to the connect syntax. The breakage was accidental and not > intended. > > I did intend to add overloads, as they're nice to use, I just hadn't > consider

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Thiago Macieira
Em quarta-feira, 13 de julho de 2016, às 16:45:05 PDT, Ola Røer Thorsen escreveu: > In my opinion, please try to avoid these overloads as much as possible. That's the current policy. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Thiago Macieira
Em quarta-feira, 13 de julho de 2016, às 10:44:13 PDT, Alexander Blasche escreveu: > Hi, > > Yesterday, I stumbled over a break in QtSerialBus due to the addition of new > QTimer::setInterval(..) overloads in qtbase/dev. This was introduced by > > https://codereview.qt-project.org/#/c/160889/ >

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Ola Røer Thorsen
2016-07-13 16:30 GMT+02:00 Simon Hausmann : > > It all comes down to the question: What impression do we want to give > people when they upgrade to > > a newer version of Qt? > > > In my experience, I first had problems with this when I converted to the new "connect" syntax some years ago and hit

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Simon Hausmann
behalf of Giuseppe D'Angelo Sent: Wednesday, July 13, 2016 4:16:39 PM To: development@qt-project.org Subject: Re: [Development] Source break policy for function overloads Il 13/07/2016 15:55, Simon Hausmann ha scritto: > > I think if we allow source compatibility breakages like t

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Giuseppe D'Angelo
Il 13/07/2016 15:55, Simon Hausmann ha scritto: I think if we allow source compatibility breakages like the one here (overloaded slot added), then I think it should require a prominent notice in the changelog / release notes. Note that setInterval is not even a slot (but an overload of start(

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Simon Hausmann
s overloads the error messages are crap and I think we should make an effort help our users. Simon From: Development on behalf of Jędrzej Nowacki Sent: Wednesday, July 13, 2016 1:39:19 PM To: development@qt-project.org Subject: Re: [Development] Source b

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Giuseppe D'Angelo
Il 13/07/2016 12:44, Alexander Blasche ha scritto: While talking to several devs in the office I could not find a congruent opinion on this issue. Do we or even can we care? Do we have a policy? While it would be nice not to add overloads to signals and slots, and we can keep an eye on that,

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Kai Koehne
> -Original Message- > From: Development [mailto:development-bounces+kai.koehne=qt.io@qt- > [...] > We do not have SC promise only BC. We tend to not break SC without > reason, for example we avoid juggling with header files just to "cleanup" > stuff, but definitely we reserve right to a

Re: [Development] Source break policy for function overloads

2016-07-13 Thread Jędrzej Nowacki
On Wednesday 13 of July 2016 10:44:13 Alexander Blasche wrote: > Hi, > > Yesterday, I stumbled over a break in QtSerialBus due to the addition of new > QTimer::setInterval(..) overloads in qtbase/dev. This was introduced by > > https://codereview.qt-project.org/#/c/160889/ > > Unfortunately this

[Development] Source break policy for function overloads

2016-07-13 Thread Alexander Blasche
Hi, Yesterday, I stumbled over a break in QtSerialBus due to the addition of new QTimer::setInterval(..) overloads in qtbase/dev. This was introduced by https://codereview.qt-project.org/#/c/160889/ Unfortunately this has the undesirable side effect that lines like: q->connect(q, &QModbusClie