Re: [Development] Seeking advise using git and code review

2017-10-04 Thread Edward Welbourne
Daniel Savi: >> When checking the branch with "git branch", I found that I was on a >> detached head now. André Hartmann (4 October 2017 09:25) > That sounds like you didn't work on a local branch, but rather on the > remote branch. When commiting there, you go into detached head. But > that's no

Re: [Development] Seeking advise using git and code review

2017-10-04 Thread André Hartmann
Hi Daniel, thanks for your first contribution. Reading your message remembers me when I started learning Git and contributing to Qt (Creator) some years back ... The others already said very important things, so I'm just concentrating on one: > When checking the branch with "git branch",

Re: [Development] Seeking advise using git and code review

2017-10-04 Thread Samuel Gaist
> On 4 Oct 2017, at 08:55, Daniel Savi wrote: > > Hello everybody Hi and welcome new contributor :) > > I've just pushed my first commit to QtGui, trying to follow the contribution > guidelines posted here http://wiki.qt.io/Qt_Contribution_Guidelines. Now I > have some questions regarding t

Re: [Development] Seeking advise using git and code review

2017-10-04 Thread Jean-Michaël Celerier
> After pushing my changes, the sanity bot found some typos in my commit message. Now, how would I proceed? Do I change the commit message? If so, how would I do that? IIRC you do your modifications, do a git commit --amend, keep the same code review ID in the commit message and push the new set o

[Development] Seeking advise using git and code review

2017-10-03 Thread Daniel Savi
Hello everybody I've just pushed my first commit to QtGui, trying to follow the contribution guidelines posted here http://wiki.qt.io/Qt_Contribution_Guidelines. Now I have some questions regarding the process. It seems that I have done it at least partly wrong ;-) The codereview to my chan