I've settled for the syntax now. See
http://qt-project.org/wiki/Coding-Conventions . Kai convinced me that
qt_x11_p.h is actually special because it #undef's some things other
headers may need.
--
Ulf Hermann, Software Engineer - Digia, Qt
Digia Germany GmbH, Rudower Chaussee 13, D-12489 Berl
Em seg 17 fev 2014, às 12:04:10, Koehne Kai escreveu:
> I did a quick reality check on this one:
> https://codereview.qt-project.org/#change,78318 changes all _p.h includes
> to a canonical format, and I couldn't measure any
> difference when compiling on windows (where filesystem accesses are
> t
ect: Re: [Development] Rules for including private headers
>
> > Sounds good to me. From what I read below, you just add the section
> > about private headers, right?
>
> Yes.
>
> >> * If you need to include qt_x11_p.h, always include it as the last
> >> header
On Monday 17. February 2014 10.46.12 Ulf Hermann wrote:
> > Sounds good to me. From what I read below, you just add the section about
> > private headers, right?
>
> Yes.
>
> >> * If you need to include qt_x11_p.h, always include it as the last
> >> header file.
> >
> > This could go into the pr
> Sounds good to me. From what I read below, you just add the section about
> private headers, right?
Yes.
>> * If you need to include qt_x11_p.h, always include it as the last
>> header file.
> This could go into the private headers section since it's private itself.
I'd rather just delete it.
On Fri, Feb 14, 2014 at 10:03 AM, Ulf Hermann wrote:
> Hello,
>
> as I just got bitten by it (see
> https://codereview.qt-project.org/#change,78128) I'd really like to
> clarify our rules for including private headers in Qt.
> http://qt-project.org/wiki/Coding-Conventions#32bc73e08b315a2d85bfd10b2
Em sex 14 fev 2014, às 11:03:02, Ulf Hermann escreveu:
> If you need to include private headers there are four cases with
> different syntax. Various build system magic makes those possible but
> that will not be discussed here.
>
> 1. The header, e.g. whatever_p.h, is in the same directory as t
Fredag 14. februar 2014 11.03.02 skrev Ulf Hermann:
> Hello,
>
> as I just got bitten by it (see
> https://codereview.qt-project.org/#change,78128) I'd really like to
> clarify our rules for including private headers in Qt.
> http://qt-project.org/wiki/Coding-Conventions#32bc73e08b315a2d85bfd10b2e
Hello,
as I just got bitten by it (see
https://codereview.qt-project.org/#change,78128) I'd really like to
clarify our rules for including private headers in Qt.
http://qt-project.org/wiki/Coding-Conventions#32bc73e08b315a2d85bfd10b2e8c867a
has a few notes on that but they're not very conclusi
