Re: [Development] Requesting a wip/qt6 branch for QtSerialBus

2018-10-03 Thread Thiago Macieira
On Wednesday, 3 October 2018 08:26:27 PDT Shawn Rutledge wrote: > > note that the qt(core) code is already full of QT_VERSION_CHECK(6,0,0) > > which does effectively the same, but to activate it you would need to > > change .qmake.conf instead of just calling configure -qt6. > > I’ve written those

Re: [Development] Requesting a wip/qt6 branch for QtSerialBus

2018-10-03 Thread Shawn Rutledge
> On 2 Oct 2018, at 13:08, Oswald Buddenhagen wrote: > > in fact, the introduction of a respective configure feature (so you > would #if QT_CONFIG(qt6)) has been on the table for quite a while > already, but nobody pushed for it yet, presumably because we haven't > officially started qt6 yet. W

Re: [Development] Requesting a wip/qt6 branch for QtSerialBus

2018-10-02 Thread André Hartmann
Hi Oswald, > the more pragmatic approach is to "hide" the qt6 variant behind ifdefs. If that is the "official" way, fine with me. > note that the qt(core) code is already full of QT_VERSION_CHECK(6,0,0) > which does effectively the same, but to activate it you would need to > change .qmake.conf

Re: [Development] Requesting a wip/qt6 branch for QtSerialBus

2018-10-02 Thread Oswald Buddenhagen
On Tue, Oct 02, 2018 at 10:37:24AM +0200, André Hartmann wrote: > I allready have some ideas for QCanBusDevice which requires > binary-incompatible changes and therefore needs to be done for Qt6 [1]. > > To be able to already start the work, I'm hereby requesting a wip branch > that could be mer

[Development] Requesting a wip/qt6 branch for QtSerialBus

2018-10-02 Thread André Hartmann
Hi all, I allready have some ideas for QCanBusDevice which requires binary-incompatible changes and therefore needs to be done for Qt6 [1]. To be able to already start the work, I'm hereby requesting a wip branch that could be merged when the "real" Qt6 development begins. The advantage wou