Re: [Development] Removing fromUtf8() fallback in QStringLiteral

2017-02-09 Thread Marc Mutz
On Thursday 09 February 2017 18:14:47 Olivier Goffart wrote: > On Donnerstag, 9. Februar 2017 17:32:42 CET Marc Mutz wrote: > > On Thursday 09 February 2017 10:41:05 Marc Mutz wrote: > > > AFAICT, (2) could only possibly affect ICC and VxWorks. > > > > From the change set: > > > > - VxWorks uses

Re: [Development] Removing fromUtf8() fallback in QStringLiteral

2017-02-09 Thread Thiago Macieira
On quinta-feira, 9 de fevereiro de 2017 10:41:05 PST Marc Mutz wrote: > 1. To have this patch merged for 5.8 instead of dev I agree, because I consider that you're not changing behaviour. There should be no one left using the fromUtf8 branch. -- Thiago Macieira - thiago.macieira (AT) intel.com

Re: [Development] Removing fromUtf8() fallback in QStringLiteral

2017-02-09 Thread Olivier Goffart
On Donnerstag, 9. Februar 2017 17:32:42 CET Marc Mutz wrote: > On Thursday 09 February 2017 10:41:05 Marc Mutz wrote: > > AFAICT, (2) could only possibly affect ICC and VxWorks. > > From the change set: > > - VxWorks uses GCC 4.8, that's enough. > - The ICC minimum version since Qt 5.7 (cf. dist/

Re: [Development] Removing fromUtf8() fallback in QStringLiteral

2017-02-09 Thread Marc Mutz
On Thursday 09 February 2017 10:41:05 Marc Mutz wrote: > AFAICT, (2) could only possibly affect ICC and VxWorks. >From the change set: - VxWorks uses GCC 4.8, that's enough. - The ICC minimum version since Qt 5.7 (cf. dist/changes-5._6_.0) is v14 (Unicode string literals were added for 12.1), s

[Development] Removing fromUtf8() fallback in QStringLiteral

2017-02-09 Thread Marc Mutz
Hi, https://codereview.qt-project.org/185059 proposes to remove support for the fromUtf8() fallback of QStringLiteral, so we can finally guarantee that QStringLiteral use will not allocate memory and will not throw. I believe we can get away with it (see comment in change set for details) sinc