Oswald Buddenhagen wrote:
>> That's why I am asking that, if people are going to submit rebases,
>> submit ONLY the rebase, with no extra changes.
>>
> well, that's noble, but it just won't happen in most cases. been there,
> tried it, didn't even get a t-shirt.
How about this, you decide to reba
On Thu, Nov 24, 2011 at 12:21:55AM +0100, ext Thiago Macieira wrote:
> On Wednesday, 23 de November de 2011 21:33:14 Oswald Buddenhagen wrote:
> > On Wed, Nov 23, 2011 at 07:07:17PM +0100, ext Thiago Macieira wrote:
> > > So, if I have reviewed your patch #6 in the contribution and you
> > > need t
On Wednesday, 23 de November de 2011 21:33:14 Oswald Buddenhagen wrote:
> On Wed, Nov 23, 2011 at 07:07:17PM +0100, ext Thiago Macieira wrote:
> > So, if I have reviewed your patch #6 in the contribution and you need to
> > rebase in order to modify something, then rebase, push #7, leave a comment
On Wed, Nov 23, 2011 at 07:07:17PM +0100, ext Thiago Macieira wrote:
> So, if I have reviewed your patch #6 in the contribution and you need to
> rebase in order to modify something, then rebase, push #7, leave a comment
> saying it was a rebase, modify and submit #8. That way, I can compare #7 t
Hello
Here's a recommendation for submitting rebased changes to Gerrit, coming from
someone who likes to compare different versions of a submission.
When you rebase, submit the rebase *only*. Do not change anything in your
contribution. Then add a comment saying you rebased, so that a reviewer wi
