Re: [Development] Qt5 release integration build

2013-12-11 Thread Thiago Macieira
On quarta-feira, 11 de dezembro de 2013 13:30:15, Friedemann Kleint wrote: > The usual technique for fixing warnings is to push one change per > warning type for easier review (for example, fix all signed/unsigned > comparisons in one change). If it's not obvious what the warning you're fixing i

Re: [Development] Qt5 release integration build

2013-12-11 Thread Friedemann Kleint
Hi, >I suppose that the warnings in the list beneath are still unsolved. Is that correct? >How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the >list below is a synopsis). The li

Re: [Development] Qt5 release integration build

2013-12-11 Thread Mitch Curtis
On 12/10/2013 08:18 PM, Kurt Pattyn wrote: > Thanks for the info. Is there a target date for 5.2.1? > > I want to give a helping hand, but how can this be coordinated so that > no two people are fixing the same warnings? I don't think that you'll have that problem! :D > > Regards, > Kurt > > On 1

Re: [Development] Qt5 release integration build

2013-12-10 Thread Thiago Macieira
On terça-feira, 10 de dezembro de 2013 20:06:24, Kurt Pattyn wrote: > How critical is it to solve those warnings? If they are critical for the > release, I want to give a helping hand to remove them (after all there are > more than 900, the list below is a synopsis). MSVC warnings are not critical

Re: [Development] Qt5 release integration build

2013-12-10 Thread Thiago Macieira
On terça-feira, 10 de dezembro de 2013 20:18:11, Kurt Pattyn wrote: > Thanks for the info. Is there a target date for 5.2.1? See the minutes for yesterday's release team meeting. It's going to be either January of February, depending on the timing of Qt 4.8.6. -- Thiago Macieira - thiago.macieir

Re: [Development] Qt5 release integration build

2013-12-10 Thread Kurt Pattyn
Thanks for the info. Is there a target date for 5.2.1? I want to give a helping hand, but how can this be coordinated so that no two people are fixing the same warnings? Regards, Kurt On 10 Dec 2013, at 20:13, Liang Qi wrote: > Those changes happened in stable branch, it means they will be pa

Re: [Development] Qt5 release integration build

2013-12-10 Thread Liang Qi
Those changes happened in stable branch, it means they will be part of 5.2.1, then doesn't block 5.2.0 final release. Anyway, patches are welcome! Regards, Liang On 10 December 2013 20:06, Kurt Pattyn wrote: > I suppose that the warnings in the list beneath are still unsolved. Is > that corre

Re: [Development] Qt5 release integration build

2013-12-10 Thread Kurt Pattyn
I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). Cheers, Kurt On

Re: [Development] Qt5 release integration build

2013-12-10 Thread Mitch Curtis
https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https

[Development] Qt5 release integration build

2013-12-10 Thread Kurt Pattyn
Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.tx