Re: [Development] Qt 5.6.0 header diff: QtTest.diff

2015-09-18 Thread Milian Wolff
On Donnerstag, 17. September 2015 09:15:06 CEST Thiago Macieira wrote: > On Thursday 17 September 2015 15:27:44 Milian Wolff wrote: > > +++ b/src/testlib/qtestaccessible.h > > > > @@ -126,7 +126,7 @@ public: > > static void cleanup() > > { > > > > delete instance(); > > >

Re: [Development] Qt 5.6.0 header diff: QtTest.diff

2015-09-17 Thread Thiago Macieira
On Thursday 17 September 2015 15:27:44 Milian Wolff wrote: > +++ b/src/testlib/qtestaccessible.h > @@ -126,7 +126,7 @@ public: > static void cleanup() > { > delete instance(); > -instance() = 0; > +instance() = Q_NULLPTR; > } > > this is wrong Why? -- Thia

Re: [Development] Qt 5.6.0 header diff: QtTest.diff

2015-09-17 Thread Milian Wolff
+++ b/src/testlib/qtestaccessible.h @@ -126,7 +126,7 @@ public: static void cleanup() { delete instance(); -instance() = 0; +instance() = Q_NULLPTR; } this is wrong +++ b/src/testlib/qtestmouse.h @@ -45,6 +45,7 @@ #include #include #include +#include

[Development] Qt 5.6.0 header diff: QtTest.diff

2015-09-17 Thread Frederik Gladhorn
diff --git a/src/testlib/qsignalspy.h b/src/testlib/qsignalspy.h index cfde89a..1751220 100644 --- a/src/testlib/qsignalspy.h +++ b/src/testlib/qsignalspy.h @@ -82,7 +82,7 @@ public: } if (!QMetaObject::connect(obj, sigIndex, this, memberOffset, -Qt::DirectCo